Bug 20350 - [GTK] Get DumpRenderTree working
Summary: [GTK] Get DumpRenderTree working
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
Keywords: Gtk
Depends on:
Reported: 2008-08-11 16:07 PDT by Alp Toker
Modified: 2008-08-18 04:15 PDT (History)
1 user (show)

See Also:

DRT fixes (17.95 KB, patch)
2008-08-16 15:19 PDT, Alp Toker
zecke: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alp Toker 2008-08-11 16:07:25 PDT
DumpRenderTree is a valuable tool for automated testing. Attached patch completes basic functionality (without pixel dump or input event synthesis support).

Due to differences in fonts and metrics between Mac and GTK+ many of the render tree outputs don't match the existing ones in SVN. It's probably best to solve this (perhaps by loading custom fonts for DRT) before checking in any test results and enabling this on the build bot.

First impressions look good. About 50% of the tests pass, another 40% generate new reference output and the rest are failures or crashers (I'm fixing a few of these).
Comment 1 Mark Rowe (bdash) 2008-08-11 16:22:58 PDT
A good first step may be to add a flag to run-webkit-tests that has it ignore non-text-only results (eg, render tree dumps).  Dealing with the font metric issue for render trees is rather tricky, and I think a lot more benefit can be gained from a) fixing the obvious crashers, and b) fixing any text-only tests that fail, before working on the render tree side of things.
Comment 2 Alp Toker 2008-08-16 15:19:49 PDT
Created attachment 22835 [details]
DRT fixes

Fixes and enhancements to GTK+'s DRT tool.
Comment 3 Holger Freyther 2008-08-17 06:16:04 PDT
Comment on attachment 22835 [details]
DRT fixes

Great step ahead.

You should get various new unused parameter warnings, e.g. just omit the parameter name and you are fine.

The flushing should fix quite some issues.

The cosmetic changes are I fine and besides personal taste I could not find anything in the Coding Style Guidelines to forbid comments at the end of the line.

The removal of WorkQueue::shared()->clear() and addition of webkit_web_view_open is something the other DRTs don't do. You are definitely right that some results depend on the order of the tests...
Comment 4 Jan Alonzo 2008-08-18 04:15:47 PDT
landed in r35816