Bug 203496 - Expose _printOperationWithPrintInfo: SPI as API
Summary: Expose _printOperationWithPrintInfo: SPI as API
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit API (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brady Eidson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-10-28 11:38 PDT by Brady Eidson
Modified: 2019-10-28 14:42 PDT (History)
2 users (show)

See Also:

Attachments
Patch (4.35 KB, patch)
2019-10-28 11:40 PDT, Brady Eidson 		no flags Details | Formatted Diff | Diff
Patch (4.28 KB, patch)
2019-10-28 12:29 PDT, Brady Eidson 		no flags Details | Formatted Diff | Diff
Patch (4.27 KB, patch)
2019-10-28 13:00 PDT, Brady Eidson 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2019-10-28 11:38:48 PDT 
Expose _printOperationWithPrintInfo: SPI as API
Comment 1 Brady Eidson 2019-10-28 11:39:04 PDT 
<rdar://problem/36557179>
Comment 2 Brady Eidson 2019-10-28 11:40:57 PDT 
Created attachment 382086 [details]
Patch
Comment 3 Andy Estes 2019-10-28 11:44:02 PDT 
Comment on attachment 382086 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=382086&action=review

> Source/WebKit/UIProcess/API/Cocoa/WKWebView.h:307
> +/* @abstract Returns an NSPrintOperation object configured to print the contents of this WKWebView
> +@param printInfo The print info object used to configure the resulting print operation.
> +*/
> +- (NSPrintOperation *)printOperationWithPrintInfo:(NSPrintInfo *)printInfo WK_API_AVAILABLE(macos(WK_MAC_TBA));
> +

Should this be part of one of the !TARGET_OS_IPHONE sections either above or below?
Comment 4 Brady Eidson 2019-10-28 12:29:16 PDT 
Created attachment 382094 [details]
Patch
Comment 5 Brady Eidson 2019-10-28 13:00:33 PDT 
Created attachment 382097 [details]
Patch
Comment 6 WebKit Commit Bot 2019-10-28 14:42:50 PDT 
Comment on attachment 382097 [details]
Patch

Clearing flags on attachment: 382097

Committed r251673: <https://trac.webkit.org/changeset/251673>
Comment 7 WebKit Commit Bot 2019-10-28 14:42:51 PDT 
All reviewed patches have been landed.  Closing bug.