Bug 203491 - Layout Test http/tests/resourceLoadStatistics/website-data-removal-for-site-navigated-to-with-link-decoration.html is a flaky failure
Summary: Layout Test http/tests/resourceLoadStatistics/website-data-removal-for-site-n...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kate Cheney
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-10-28 10:30 PDT by Kate Cheney
Modified: 2019-10-28 14:38 PDT (History)
5 users (show)

See Also:

Attachments
Patch (10.20 KB, patch)
2019-10-28 10:47 PDT, Kate Cheney 		no flags Details | Formatted Diff | Diff
Patch (10.07 KB, patch)
2019-10-28 11:17 PDT, Kate Cheney 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kate Cheney 2019-10-28 10:30:10 PDT 
Previously fixed in <rdar://problem/51074251>. Started flaking again after fixing <rdar://problem/56314484>.
Comment 1 Radar WebKit Bug Importer 2019-10-28 10:31:12 PDT 
<rdar://problem/56674176>
Comment 2 Kate Cheney 2019-10-28 10:47:46 PDT 
Created attachment 382081 [details]
Patch
Comment 3 Chris Dumez 2019-10-28 10:52:25 PDT 
Comment on attachment 382081 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=382081&action=review

> Source/WebKit/NetworkProcess/NetworkSession.cpp:181
> +    if (!networkProcess().isITPDatabaseEnabled())

Instead of having these checks at call sites, could we maybe call populateMemoryStoreFromDisk() unconditionally and add a null check for the persistent store in  populateMemoryStoreFromDisk()?
Comment 4 Kate Cheney 2019-10-28 11:17:08 PDT 
Created attachment 382084 [details]
Patch
Comment 5 Kate Cheney 2019-10-28 13:50:30 PDT 
(In reply to Chris Dumez from comment #3)
> Comment on attachment 382081 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=382081&action=review
> 
> > Source/WebKit/NetworkProcess/NetworkSession.cpp:181
> > +    if (!networkProcess().isITPDatabaseEnabled())
> 
> Instead of having these checks at call sites, could we maybe call
> populateMemoryStoreFromDisk() unconditionally and add a null check for the
> persistent store in  populateMemoryStoreFromDisk()?

Thanks! Still waiting on commit privileges, can you cq+?
Comment 6 WebKit Commit Bot 2019-10-28 14:38:33 PDT 
Comment on attachment 382084 [details]
Patch

Clearing flags on attachment: 382084

Committed r251672: <https://trac.webkit.org/changeset/251672>
Comment 7 WebKit Commit Bot 2019-10-28 14:38:35 PDT 
All reviewed patches have been landed.  Closing bug.