Bug 203486 - dumpSpeculation in SpeculatedType.cpp prints to the wrong stream and has wrong capitalization for NaN
Summary: dumpSpeculation in SpeculatedType.cpp prints to the wrong stream and has wron...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Trivial
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-10-28 06:53 PDT by Tuomas Karkkainen
Modified: 2019-10-28 13:28 PDT (History)
9 users (show)

See Also:


Attachments
proposed patch (1.38 KB, patch)
2019-10-28 06:58 PDT, Tuomas Karkkainen
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tuomas Karkkainen 2019-10-28 06:53:40 PDT
in void dumpSpeculation(PrintStream& outStream, SpeculatedType value)
 in SpeculatedType.cpp, "DoubleImpureNan" is printed to out when it should be printed to strOut.

also DoubleImpureNan and DoublePureNan should both end with a capital N.
Comment 1 Tuomas Karkkainen 2019-10-28 06:58:05 PDT
Created attachment 382067 [details]
proposed patch
Comment 2 WebKit Commit Bot 2019-10-28 13:21:55 PDT
Comment on attachment 382067 [details]
proposed patch

Clearing flags on attachment: 382067

Committed r251667: <https://trac.webkit.org/changeset/251667>
Comment 3 WebKit Commit Bot 2019-10-28 13:21:56 PDT
All reviewed patches have been landed.  Closing bug.
Comment 4 Radar WebKit Bug Importer 2019-10-28 13:28:52 PDT
<rdar://problem/56682260>