Bug 203484 - CSS Transitions and CSS Animations properties should treat unitless 0 as an invalid value for times
Summary: CSS Transitions and CSS Animations properties should treat unitless 0 as an i...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Animations (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antoine Quint
URL:
Keywords: InRadar
: 204947 (view as bug list)
Depends on:
Blocks: 203477
  Show dependency tree / graph
 
Reported: 2019-10-28 03:20 PDT by Antoine Quint
Modified: 2019-12-10 10:58 PST (History)
11 users (show)

See Also:

Attachments
Patch (9.63 KB, patch)
2019-10-28 03:23 PDT, Antoine Quint 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews213 for win-future (14.26 MB, application/zip)
2019-10-28 04:41 PDT, EWS Watchlist 		no flags Details
Patch (18.66 KB, patch)
2019-10-28 08:34 PDT, Antoine Quint 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antoine Quint 2019-10-28 03:20:47 PDT 
CSS Transitions and CSS Animations properties should treat unitless 0 as an invalid value for times
Comment 1 Antoine Quint 2019-10-28 03:23:34 PDT 
Created attachment 382060 [details]
Patch
Comment 2 Antti Koivisto 2019-10-28 03:26:57 PDT 
Comment on attachment 382060 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=382060&action=review

> Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp:450
> +    bool acceptUnitless = token.type() == NumberToken && unitless == UnitlessQuirk::Allow && shouldAcceptUnitlessValue(token.numericValue(), cssParserMode, unitless);

Why does it still need to be accepted in quirks mode?
Comment 3 Antoine Quint 2019-10-28 03:32:02 PDT 
(In reply to Antti Koivisto from comment #2)
> Comment on attachment 382060 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=382060&action=review
> 
> > Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp:450
> > +    bool acceptUnitless = token.type() == NumberToken && unitless == UnitlessQuirk::Allow && shouldAcceptUnitlessValue(token.numericValue(), cssParserMode, unitless);
> 
> Why does it still need to be accepted in quirks mode?

This is so -webkit-marquee-speed, which is the only property for which UnitlessQuirk is set to Allow, does not change behavior. Only transition-delay, animation-duration and animation-delay are affected.
Comment 4 EWS Watchlist 2019-10-28 04:41:25 PDT 
Comment on attachment 382060 [details]
Patch

Attachment 382060 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/13184947

New failing tests:
css1/units/zero-duration-without-units.html
transitions/zero-duration-without-units.html
animations/fill-mode-forwards-zero-duration.html
legacy-animation-engine/animations/fill-mode-forwards-zero-duration.html
css3/filters/blur-various-radii.html
legacy-animation-engine/compositing/animation/keyframe-order.html
transitions/zero-duration-in-list.html
Comment 5 EWS Watchlist 2019-10-28 04:41:27 PDT 
Created attachment 382066 [details]
Archive of layout-test-results from ews213 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews213  Port: win-future  Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit
Comment 6 Antoine Quint 2019-10-28 08:34:47 PDT 
Created attachment 382073 [details]
Patch
Comment 7 Antoine Quint 2019-10-28 10:02:05 PDT 
Committed r251658: <https://trac.webkit.org/changeset/251658>
Comment 8 Radar WebKit Bug Importer 2019-10-28 10:03:18 PDT 
<rdar://problem/56672826>
Comment 9 Antoine Quint 2019-12-09 01:37:25 PST 
*** Bug 204947 has been marked as a duplicate of this bug. ***