Bug 203484 – CSS Transitions and CSS Animations properties should treat unitless 0 as an invalid value for times

• Status: RESOLVED
• Resolution: FIXED
• Component: Animations

[Antoine Quint]

CSS Transitions and CSS Animations properties should treat unitless 0 as an invalid value for times

[Antoine Quint]

Created attachment 382060 [details]
Patch

[Antti Koivisto]

Comment on attachment 382060 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=382060&action=review

> Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp:450
> +    bool acceptUnitless = token.type() == NumberToken && unitless == UnitlessQuirk::Allow && shouldAcceptUnitlessValue(token.numericValue(), cssParserMode, unitless);

Why does it still need to be accepted in quirks mode?

[Antoine Quint]

(In reply to Antti Koivisto from comment #2)
> Comment on attachment 382060 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=382060&action=review
> 
> > Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp:450
> > +    bool acceptUnitless = token.type() == NumberToken && unitless == UnitlessQuirk::Allow && shouldAcceptUnitlessValue(token.numericValue(), cssParserMode, unitless);
> 
> Why does it still need to be accepted in quirks mode?

This is so -webkit-marquee-speed, which is the only property for which UnitlessQuirk is set to Allow, does not change behavior. Only transition-delay, animation-duration and animation-delay are affected.

[EWS Watchlist]

Comment on attachment 382060 [details]
Patch

Attachment 382060 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/13184947

New failing tests:
css1/units/zero-duration-without-units.html
transitions/zero-duration-without-units.html
animations/fill-mode-forwards-zero-duration.html
legacy-animation-engine/animations/fill-mode-forwards-zero-duration.html
css3/filters/blur-various-radii.html
legacy-animation-engine/compositing/animation/keyframe-order.html
transitions/zero-duration-in-list.html

[EWS Watchlist]

Created attachment 382066 [details]
Archive of layout-test-results from ews213 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews213  Port: win-future  Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit

[Antoine Quint]

Created attachment 382073 [details]
Patch

[Antoine Quint]

Committed r251658: <https://trac.webkit.org/changeset/251658>

[Radar WebKit Bug Importer]

<rdar://problem/56672826>

[Antoine Quint]

*** Bug 204947 has been marked as a duplicate of this bug. ***