Bug 203472 - [Quick Look] Clean up LegacyPreviewLoaderClients
Summary: [Quick Look] Clean up LegacyPreviewLoaderClients
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andy Estes
Keywords: InRadar
Depends on:
Reported: 2019-10-27 13:17 PDT by Andy Estes
Modified: 2019-10-29 21:15 PDT (History)
11 users (show)

See Also:

Patch (45.50 KB, patch)
2019-10-27 13:27 PDT, Andy Estes
no flags Details | Formatted Diff | Diff
Patch (52.51 KB, patch)
2019-10-29 14:48 PDT, Andy Estes
no flags Details | Formatted Diff | Diff
Patch (52.51 KB, patch)
2019-10-29 16:51 PDT, Andy Estes
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andy Estes 2019-10-27 13:17:42 PDT
[Quick Look] Clean up LegacyPreviewLoaderClients
Comment 1 Andy Estes 2019-10-27 13:27:27 PDT
Created attachment 382032 [details]
Comment 2 Andy Estes 2019-10-29 14:48:30 PDT
Created attachment 382230 [details]
Comment 3 Brady Eidson 2019-10-29 16:35:34 PDT
Comment on attachment 382230 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=382230&action=review

> Source/WebKit/Platform/SharedMemory.cpp:35
> +RefPtr<SharedMemory> SharedMemory::create(const SharedBuffer& buffer)

I was a little confused here, trying to figure out how you could make an existing become "shared memory"

I'd like the name to be more clear that the new SharedMemory object is a copy.

Maybe "createWithCopy" or something explicit like that.

> Source/WebKit/Platform/SharedMemory.h:104
>      static RefPtr<SharedMemory> create(void*, size_t, Protection);
> +    static RefPtr<SharedMemory> create(const WebCore::SharedBuffer&);

I know the existence of this one is just as confusing. I would've made the same comment when it was added. (Unless, of course,I am the one who added it)
Comment 4 Andy Estes 2019-10-29 16:51:56 PDT
Created attachment 382252 [details]
Comment 5 WebKit Commit Bot 2019-10-29 21:14:47 PDT
Comment on attachment 382252 [details]

Clearing flags on attachment: 382252

Committed r251765: <https://trac.webkit.org/changeset/251765>
Comment 6 WebKit Commit Bot 2019-10-29 21:14:49 PDT
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2019-10-29 21:15:19 PDT