[Quick Look] Clean up LegacyPreviewLoaderClients
Created attachment 382032 [details]
Created attachment 382230 [details]
Comment on attachment 382230 [details]
View in context: https://bugs.webkit.org/attachment.cgi?id=382230&action=review
> +RefPtr<SharedMemory> SharedMemory::create(const SharedBuffer& buffer)
I was a little confused here, trying to figure out how you could make an existing become "shared memory"
I'd like the name to be more clear that the new SharedMemory object is a copy.
Maybe "createWithCopy" or something explicit like that.
> static RefPtr<SharedMemory> create(void*, size_t, Protection);
> + static RefPtr<SharedMemory> create(const WebCore::SharedBuffer&);
I know the existence of this one is just as confusing. I would've made the same comment when it was added. (Unless, of course,I am the one who added it)
Created attachment 382252 [details]
Comment on attachment 382252 [details]
Clearing flags on attachment: 382252
Committed r251765: <https://trac.webkit.org/changeset/251765>
All reviewed patches have been landed. Closing bug.