RESOLVED FIXED 20347
[XBL] Add support for DocumentXBL interface 
https://bugs.webkit.org/show_bug.cgi?id=20347
Summary [XBL] Add support for DocumentXBL interface
Julien Chaffraix
Reported 2008-08-11 14:26:34 PDT
http://www.w3.org/TR/xbl/#the-documentxbl
Attachments
Proposed implementation, leaving document loading as the rest is not ready (22.87 KB, patch)
2008-08-11 18:28 PDT, Julien Chaffraix 		eric: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Julien Chaffraix
Comment 1 2008-08-11 18:28:51 PDT
Created attachment 22738 [details] Proposed implementation, leaving document loading as the rest is not ready
Eric Seidel (no email)
Comment 2 2008-08-12 17:04:28 PDT
Comment on attachment 22738 [details] Proposed implementation, leaving document loading as the rest is not ready In general looks fine. You should change the argument names attrName and name to be documentURI where appropriate. You really should be using the newer "fast/js" testing framework, with shouldBe, etc. There is TEMPLATE.html inside resources and make-js-test-wrappers. In general this looks fine. I'd like to see you fix the tests to the new system before landing. Once you learn it, I think you'll find writing tests are much easier (just ask WildFox). :)
Julien Chaffraix
Comment 3 2008-08-18 13:54:17 PDT
Committed in r35822 using the nice fast/js framework :).
Note You need to log in before you can comment on or make changes to this bug.