Bug 203464 – Fix nth-child An+B serialization to match the spec

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Simon Fraser (smfr)]

Fix nth-child An+B serialization to match the spc

[Simon Fraser (smfr)]

Created attachment 382019 [details]
Patch

[Radar WebKit Bug Importer]

<rdar://problem/56648385>

[EWS Watchlist]

Comment on attachment 382019 [details]
Patch

Attachment 382019 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/13181963

New failing tests:
css3/parsing-css3-nthchild.html
fast/dom/css-selectorText.html
css3/filters/blur-various-radii.html

[EWS Watchlist]

Created attachment 382020 [details]
Archive of layout-test-results from ews211 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews211  Port: win-future  Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit

[Sam Weinig]

Comment on attachment 382019 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=382019&action=review

> Source/WebCore/css/CSSSelector.cpp:425
> +        str.append("n+");
> +        str.append(b);

StringBuilder::append supports a variable number of arguments, so this (and the one above) can be written as str.append("n+", b); It is slightly more efficient.

[Simon Fraser (smfr)]

Created attachment 382023 [details]
Patch

[Antti Koivisto]

Comment on attachment 382023 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=382023&action=review

Astonishing amount of test coverage for something of so little significance!

> Source/WebCore/css/CSSSelector.cpp:393
> +{

'str' is not a great name (yes, that's what the existing code uses).

[Simon Fraser (smfr)]

https://trac.webkit.org/changeset/251647/webkit