It should show a context menu. This is NOT a regression. It's been like this for years.
Created attachment 381967 [details] Patch
Comment on attachment 381967 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=381967&action=review rs=me > Source/WebInspectorUI/UserInterface/Views/ColorSquare.js:152 > + if (event.button !== 0 || event.ctrlKey) Does this work for non-macOS systems too? Should it only check for `event.ctrlKey` if `WI.Platform.name === "mac"`?
(In reply to Devin Rousso from comment #2) > Comment on attachment 381967 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=381967&action=review > > rs=me > > > Source/WebInspectorUI/UserInterface/Views/ColorSquare.js:152 > > + if (event.button !== 0 || event.ctrlKey) > > Does this work for non-macOS systems too? Should it only check for > `event.ctrlKey` if `WI.Platform.name === "mac"`? Hm, I'm not sure. However, we use `if (event.button !== 0 || event.ctrlKey)` everywhere in Web Inspector (in 13 other places).
Comment on attachment 381967 [details] Patch I'll land this. If we decide to change Control-click behavior on non-Mac platforms, it should be a separate patch that modifies all `event.button !== 0 || event.ctrlKey` conditions, not just in the color picker.
The commit-queue encountered the following flaky tests while processing attachment 381967 [details]: webaudio/stereo2mono-down-mixing.html bug 203538 (authors: ap@webkit.org, crogers@google.com, haraken@chromium.org, mark.lam@apple.com, and sam@webkit.org) The commit-queue is continuing to process your patch.
Comment on attachment 381967 [details] Patch Clearing flags on attachment: 381967 Committed r251682: <https://trac.webkit.org/changeset/251682>
All reviewed patches have been landed. Closing bug.
<rdar://problem/56689660>