Bug 203434 – Web Inspector: Right-clicking in color picker should not select color

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Nikita Vasilyev]

It should show a context menu.

This is NOT a regression. It's been like this for years.

[Nikita Vasilyev]

Created attachment 381967 [details]
Patch

[Devin Rousso]

Comment on attachment 381967 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=381967&action=review

rs=me

> Source/WebInspectorUI/UserInterface/Views/ColorSquare.js:152
> +        if (event.button !== 0 || event.ctrlKey)

Does this work for non-macOS systems too?  Should it only check for `event.ctrlKey` if `WI.Platform.name === "mac"`?

[Nikita Vasilyev]

(In reply to Devin Rousso from comment #2)
> Comment on attachment 381967 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=381967&action=review
> 
> rs=me
> 
> > Source/WebInspectorUI/UserInterface/Views/ColorSquare.js:152
> > +        if (event.button !== 0 || event.ctrlKey)
> 
> Does this work for non-macOS systems too?  Should it only check for
> `event.ctrlKey` if `WI.Platform.name === "mac"`?

Hm, I'm not sure. However, we use `if (event.button !== 0 || event.ctrlKey)` everywhere in Web Inspector (in 13 other places).

[Nikita Vasilyev]

Comment on attachment 381967 [details]
Patch

I'll land this. If we decide to change Control-click behavior on non-Mac platforms, it should be a separate patch that modifies all `event.button !== 0 || event.ctrlKey` conditions, not just in the color picker.

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 381967 [details]:

webaudio/stereo2mono-down-mixing.html bug 203538 (authors: [e-mail], [e-mail], [e-mail], [e-mail], and [e-mail])
The commit-queue is continuing to process your patch.

[WebKit Commit Bot]

Comment on attachment 381967 [details]
Patch

Clearing flags on attachment: 381967

Committed r251682: <https://trac.webkit.org/changeset/251682>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/56689660>