Bug 20343 - [CAIRO] half functionality of border-radius
Summary: [CAIRO] half functionality of border-radius
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Nobody
URL: http://www.the-art-of-web.com/css/bor...
Keywords: Cairo
Depends on:
Blocks:
 
Reported: 2008-08-10 23:08 PDT by Dirk Schulze
Modified: 2008-09-01 05:45 PDT (History)
0 users

See Also:

Attachments
Fixes border-radius (3.81 KB, patch)
2008-08-10 23:12 PDT, Dirk Schulze 		eric: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Schulze 2008-08-10 23:08:44 PDT 
border-radius doesn't support different values for with-radius and height-radius (ellipse) and dotted or dashed borders with border-radius look strange.
Comment 1 Dirk Schulze 2008-08-10 23:12:10 PDT 
Created attachment 22724 [details]
Fixes border-radius

This is nearly a copy of the Mac-part with adaptions to cairo.
Comment 2 Eric Seidel (no email) 2008-08-22 02:27:49 PDT 
Comment on attachment 22724 [details]
Fixes border-radius

I'm not sure I 100% understand the code, but it looks sane enough.

falen really could have a better variable name.  "fa" too.

It seems sad there is not a slicker way to handle this:
+    if (w != h)
+        cairo_scale(cr, 1., scaleFactor);
+    
+    cairo_arc_negative(cr, x + hRadius, (y + vRadius) * reverseScaleFactor, hRadius, -fa * M_PI/180, -falen * M_PI/180);
+
+    if (w != h)
+        cairo_scale(cr, 1., reverseScaleFactor);
+

w/o setting and un-setting the scale factor.
Comment 3 Jan Alonzo 2008-09-01 05:45:57 PDT 
landed in r36011