RESOLVED FIXED 203426
Add SSL support for peformance dashboard database connection. 
https://bugs.webkit.org/show_bug.cgi?id=203426
Summary Add SSL support for peformance dashboard database connection.
dewei_zhu
Reported 2019-10-25 11:29:51 PDT
Add SSL support for peformance dashboard database connection.
Attachments
Patch (5.87 KB, patch)
2019-10-25 11:34 PDT, dewei_zhu 		rniwa: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
dewei_zhu
Comment 1 2019-10-25 11:34:04 PDT
Created attachment 381948 [details] Patch
Ryosuke Niwa
Comment 2 2019-10-25 13:38:01 PDT
Comment on attachment 381948 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=381948&action=review > Websites/perf.webkit.org/public/include/db.php:121 > + $connectionString = 'host=' . $databaseConfig['host'] . ' port=' . $databaseConfig['port'] > + . ' dbname=' . $databaseConfig['name'] . ' user=' . $databaseConfig['username'] . ' password=' . $databaseConfig['password']; This string concatenation is hard to read. Can we define local variables and do: "host=$host port=$port dbname=$dbname user=$user password=$password"? > Websites/perf.webkit.org/public/include/db.php:136 > + $sslConfigString .= ' ssl' . $key . '=' . $path; Why not just $sslConfigString .= "ssl $key = $path"?
dewei_zhu
Comment 3 2019-10-25 15:45:16 PDT
Landed in r251607.
Note You need to log in before you can comment on or make changes to this bug.