Bug 203426 - Add SSL support for peformance dashboard database connection.
Summary: Add SSL support for peformance dashboard database connection.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: dewei_zhu
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-10-25 11:29 PDT by dewei_zhu
Modified: 2019-10-25 15:45 PDT (History)
2 users (show)

See Also:

Attachments
Patch (5.87 KB, patch)
2019-10-25 11:34 PDT, dewei_zhu 		rniwa: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description dewei_zhu 2019-10-25 11:29:51 PDT 
Add SSL support for peformance dashboard database connection.
Comment 1 dewei_zhu 2019-10-25 11:34:04 PDT 
Created attachment 381948 [details]
Patch
Comment 2 Ryosuke Niwa 2019-10-25 13:38:01 PDT 
Comment on attachment 381948 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=381948&action=review

> Websites/perf.webkit.org/public/include/db.php:121
> +        $connectionString = 'host=' . $databaseConfig['host'] . ' port=' . $databaseConfig['port']
> +            . ' dbname=' . $databaseConfig['name'] . ' user=' . $databaseConfig['username'] . ' password=' . $databaseConfig['password'];

This string concatenation is hard to read. Can we define local variables and do:
"host=$host port=$port dbname=$dbname user=$user password=$password"?

> Websites/perf.webkit.org/public/include/db.php:136
> +                $sslConfigString .= ' ssl' . $key . '=' . $path;

Why not just $sslConfigString .= "ssl $key = $path"?
Comment 3 dewei_zhu 2019-10-25 15:45:16 PDT 
Landed in r251607.