Bug 203421 - Add a test verifying video plays well when switching from MediaStreams to regular videos
Summary: Add a test verifying video plays well when switching from MediaStreams to reg...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-10-25 09:47 PDT by youenn fablet
Modified: 2022-08-27 09:23 PDT (History)
13 users (show)

See Also:

Attachments
Patch (2.93 KB, patch)
2019-10-25 09:49 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch for landing (2.89 KB, patch)
2019-11-04 00:36 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2019-10-25 09:47:32 PDT 
Add a test verifying video plays well when switching from MediaStreams to regular videos
Comment 1 youenn fablet 2019-10-25 09:49:19 PDT 
Created attachment 381934 [details]
Patch
Comment 2 Geoffrey Garen 2019-10-25 10:39:04 PDT 
Comment on attachment 381934 [details]
Patch

r=me
Comment 3 Eric Carlson 2019-10-25 11:11:15 PDT 
Comment on attachment 381934 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=381934&action=review

> LayoutTests/fast/mediastream/stream-switch.html:17
> +        localVideo.src = "../../media/content/audio-tracks.mp4";

You can make this work cross platform by including "../../media/media-file.js" and using "localVideo.src = findMediaFile('video', 'content/test')"
Comment 4 youenn fablet 2019-11-04 00:36:27 PST 
Created attachment 382722 [details]
Patch for landing
Comment 5 WebKit Commit Bot 2019-11-04 03:35:07 PST 
Comment on attachment 382722 [details]
Patch for landing

Clearing flags on attachment: 382722

Committed r251982: <https://trac.webkit.org/changeset/251982>
Comment 6 WebKit Commit Bot 2019-11-04 03:35:08 PST 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2019-11-04 03:36:20 PST 
<rdar://problem/56860567>
Comment 8 Philippe Normand 2022-08-27 09:23:47 PDT 
(In reply to Eric Carlson from comment #3)
> Comment on attachment 381934 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=381934&action=review
> 
> > LayoutTests/fast/mediastream/stream-switch.html:17
> > +        localVideo.src = "../../media/content/audio-tracks.mp4";
> 
> You can make this work cross platform by including
> "../../media/media-file.js" and using "localVideo.src =
> findMediaFile('video', 'content/test')"

Turns out this didn't really work, see https://github.com/WebKit/WebKit/pull/3737 :)