RESOLVED FIXED 203421
Add a test verifying video plays well when switching from MediaStreams to regular videos
https://bugs.webkit.org/show_bug.cgi?id=203421
Summary Add a test verifying video plays well when switching from MediaStreams to reg...
youenn fablet
Reported 2019-10-25 09:47:32 PDT
Add a test verifying video plays well when switching from MediaStreams to regular videos
Attachments
Patch (2.93 KB, patch)
2019-10-25 09:49 PDT, youenn fablet
no flags
Patch for landing (2.89 KB, patch)
2019-11-04 00:36 PST, youenn fablet
no flags
youenn fablet
Comment 1 2019-10-25 09:49:19 PDT
Geoffrey Garen
Comment 2 2019-10-25 10:39:04 PDT
Comment on attachment 381934 [details] Patch r=me
Eric Carlson
Comment 3 2019-10-25 11:11:15 PDT
Comment on attachment 381934 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=381934&action=review > LayoutTests/fast/mediastream/stream-switch.html:17 > + localVideo.src = "../../media/content/audio-tracks.mp4"; You can make this work cross platform by including "../../media/media-file.js" and using "localVideo.src = findMediaFile('video', 'content/test')"
youenn fablet
Comment 4 2019-11-04 00:36:27 PST
Created attachment 382722 [details] Patch for landing
WebKit Commit Bot
Comment 5 2019-11-04 03:35:07 PST
Comment on attachment 382722 [details] Patch for landing Clearing flags on attachment: 382722 Committed r251982: <https://trac.webkit.org/changeset/251982>
WebKit Commit Bot
Comment 6 2019-11-04 03:35:08 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2019-11-04 03:36:20 PST
Philippe Normand
Comment 8 2022-08-27 09:23:47 PDT
(In reply to Eric Carlson from comment #3) > Comment on attachment 381934 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=381934&action=review > > > LayoutTests/fast/mediastream/stream-switch.html:17 > > + localVideo.src = "../../media/content/audio-tracks.mp4"; > > You can make this work cross platform by including > "../../media/media-file.js" and using "localVideo.src = > findMediaFile('video', 'content/test')" Turns out this didn't really work, see https://github.com/WebKit/WebKit/pull/3737 :)
Note You need to log in before you can comment on or make changes to this bug.