Bug 203398 – Add exclusion rules to text manipulation SPI

• Status: RESOLVED
• Resolution: FIXED
• Component: HTML Editing

[Ryosuke Niwa]

We need a way to exclude certain set of elements from being manipulated.

[Ryosuke Niwa]

<rdar://problem/56567256>

[Ryosuke Niwa]

Created attachment 381879 [details]
Patch

[Ryosuke Niwa]

Created attachment 381889 [details]
Yet another unified build fixes

[Ryosuke Niwa]

ping reviewers.

wincairo & mac-wk-1 failures are unrelated to this patch.

[Wenson Hsieh]

Comment on attachment 381889 [details]
Yet another unified build fixes

View in context: https://bugs.webkit.org/attachment.cgi?id=381889&action=review

> Source/WebKit/UIProcess/API/Cocoa/_WKTextManipulationToken.h:35
> +@property (nonatomic) BOOL isExcluded;

Nit - in ObjC API, boolean properties like this are usually written with an “is”-prefixed getter and a property name without the ”is”. E.g.:

@property (nonatomic, getter=isExcluded) BOOL excluded;

> Tools/TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:184
> +        [[_WKTextManipulationExclusionRule alloc] initExclusion:(BOOL)YES forElement:@"code"],

Nit - these _WKTextManipulationExclusionRules will all leak (but maybe that’s fine for an API test since the process is recreated every time?)

> Tools/TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:221
> +        [[_WKTextManipulationExclusionRule alloc] initExclusion:(BOOL)YES forAttribute:@"data-exclude" value:@"yes"],
> +        [[_WKTextManipulationExclusionRule alloc] initExclusion:(BOOL)NO forAttribute:@"data-exclude" value:@"no"],

(Ditto)

[Ryosuke Niwa]

(In reply to Wenson Hsieh from comment #5)
> Comment on attachment 381889 [details]
> Yet another unified build fixes
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=381889&action=review
> 
> > Source/WebKit/UIProcess/API/Cocoa/_WKTextManipulationToken.h:35
> > +@property (nonatomic) BOOL isExcluded;
> 
> Nit - in ObjC API, boolean properties like this are usually written with an
> “is”-prefixed getter and a property name without the ”is”. E.g.:
> 
> @property (nonatomic, getter=isExcluded) BOOL excluded;

Was wondering about that. Will fix.

> > Tools/TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:184
> > +        [[_WKTextManipulationExclusionRule alloc] initExclusion:(BOOL)YES forElement:@"code"],
> 
> Nit - these _WKTextManipulationExclusionRules will all leak (but maybe
> that’s fine for an API test since the process is recreated every time?)

Oh oops, I meant to autorelease these.

> > Tools/TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:221
> > +        [[_WKTextManipulationExclusionRule alloc] initExclusion:(BOOL)YES forAttribute:@"data-exclude" value:@"yes"],
> > +        [[_WKTextManipulationExclusionRule alloc] initExclusion:(BOOL)NO forAttribute:@"data-exclude" value:@"no"],
> 
> (Ditto)

Will do.

[Ryosuke Niwa]

Committed r251600: <https://trac.webkit.org/changeset/251600>