Bug 203392 - Fix autoscroll test specifically for iPad
Summary: Fix autoscroll test specifically for iPad
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Megan Gardner
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-10-24 17:44 PDT by Megan Gardner
Modified: 2019-10-29 15:09 PDT (History)
3 users (show)

See Also:


Attachments
Patch (2.02 KB, patch)
2019-10-24 17:48 PDT, Megan Gardner
no flags Details | Formatted Diff | Diff
Patch for landing (2.02 KB, patch)
2019-10-29 15:07 PDT, Megan Gardner
megan_gardner: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Megan Gardner 2019-10-24 17:44:26 PDT
Fix autoscroll test specifically for iPad
Comment 1 Megan Gardner 2019-10-24 17:48:51 PDT
Created attachment 381863 [details]
Patch
Comment 2 Wenson Hsieh 2019-10-24 20:24:10 PDT
Comment on attachment 381863 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=381863&action=review

> LayoutTests/ChangeLog:12
> +        thinks that there is no focused element, which then blocks the caret gesture from

I think it’s definitely worth filing a followup bugzilla bug (or radar) for this.
Comment 3 Megan Gardner 2019-10-25 14:19:02 PDT
<rdar://problem/51712479>
Comment 4 Wenson Hsieh 2019-10-25 16:52:04 PDT
(In reply to Wenson Hsieh from comment #2)
> Comment on attachment 381863 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=381863&action=review
> 
> > LayoutTests/ChangeLog:12
> > +        thinks that there is no focused element, which then blocks the caret gesture from
> 
> I think it’s definitely worth filing a followup bugzilla bug (or radar) for
> this.

Maybe we can just use https://bugs.webkit.org/show_bug.cgi?id=203264 as the followup bug to track this.
Comment 5 WebKit Commit Bot 2019-10-25 18:04:06 PDT
Comment on attachment 381863 [details]
Patch

Clearing flags on attachment: 381863

Committed r251619: <https://trac.webkit.org/changeset/251619>
Comment 6 WebKit Commit Bot 2019-10-25 18:04:08 PDT
All reviewed patches have been landed.  Closing bug.
Comment 7 Megan Gardner 2019-10-29 15:07:41 PDT
Reopening to attach new patch.
Comment 8 Megan Gardner 2019-10-29 15:07:42 PDT
Created attachment 382232 [details]
Patch for landing
Comment 9 Megan Gardner 2019-10-29 15:09:09 PDT
Accidentally re-opened and re-added patch...