Bug 203373 - [ iOS Release ]: Layout Test http/tests/navigation/page-cache-domcache-pending-promise.html is a Flaky Timeout
Summary: [ iOS Release ]: Layout Test http/tests/navigation/page-cache-domcache-pendin...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-10-24 10:50 PDT by Russell Epstein
Modified: 2019-11-22 05:29 PST (History)
10 users (show)

See Also:


Attachments
Patch (3.96 KB, patch)
2019-11-15 14:40 PST, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (4.00 KB, patch)
2019-11-18 08:15 PST, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (4.22 KB, patch)
2019-11-18 16:24 PST, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (15.71 KB, patch)
2019-11-19 10:16 PST, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Russell Epstein 2019-10-24 10:50:49 PDT
The following layout test is a flaky timeout on iOS Release:

http/tests/navigation/page-cache-domcache-pending-promise.html

Steps to Reproduce:

run-webkit-tests --ios-simulator --no-retry --no-sample-on-timeout --child-processes 1 -g --iter 100 http/tests/navigation/page-cache-domcache-pending-promise.html

Test History:

https://results.webkit.org/?suite=layout-tests&test=http%2Ftests%2Fnavigation%2Fpage-cache-domcache-pending-promise.html&platform=ios

Diff:
--- /Volumes/Data/slave/ios-simulator-13-release-tests-wk2/build/layout-test-results/http/tests/navigation/page-cache-domcache-pending-promise-expected.txt
+++ /Volumes/Data/slave/ios-simulator-13-release-tests-wk2/build/layout-test-results/http/tests/navigation/page-cache-domcache-pending-promise-actual.txt
@@ -1,15 +1,5 @@
-Tests that a page with pending DOMCache activity goes into the page cache.
+#PID UNRESPONSIVE - WebKitTestRunnerApp (pid 92071)
+FAIL: Timed out waiting for notifyDone to be called
 
-On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
-
-
-pageshow - not from cache
-pagehide - entering cache
-pageshow - from cache
-PASS Page was restored from Page Cache
-PASS Cache.add() succeeded
-PASS !!restoredFromPageCache is true
-PASS successfullyParsed is true
-
-TEST COMPLETE
-
+#EOF
+#EOF
Comment 1 Radar WebKit Bug Importer 2019-10-24 12:40:09 PDT
<rdar://problem/56590038>
Comment 2 Chris Dumez 2019-10-24 13:37:14 PDT
Looking into this now.
Comment 3 Chris Dumez 2019-10-24 13:56:27 PDT
Unfortunately, run-webkit-tests --ios-simulator --no-retry --no-sample-on-timeout --child-processes 1 -g --iter 100 http/tests/navigation/page-cache-domcache-pending-promise.htm

does NOT reproduce it for me :/
Comment 4 Alexey Proskuryakov 2019-10-24 15:17:50 PDT
This test's run time is all over the place - 1 second, 6 seconds, 26 seconds, timeout...
Comment 5 Chris Dumez 2019-10-25 16:46:00 PDT
(In reply to Chris Dumez from comment #3)
> Unfortunately, run-webkit-tests --ios-simulator --no-retry
> --no-sample-on-timeout --child-processes 1 -g --iter 100
> http/tests/navigation/page-cache-domcache-pending-promise.htm
> 
> does NOT reproduce it for me :/

No luck reproducing this on my second machine either.
Comment 6 Chris Dumez 2019-11-15 14:17:17 PST
Still not able to reproduce this.
Comment 7 Chris Dumez 2019-11-15 14:20:08 PST
I see this logging in stderr on the bots:
CONSOLE MESSAGE: line 23: Fetch API cannot load http://127.0.0.1:8000/navigation/resources/blank.txt due to access control checks.

But I think that's expected.
Comment 8 Chris Dumez 2019-11-15 14:40:26 PST
Created attachment 383652 [details]
Patch
Comment 9 Chris Dumez 2019-11-18 08:15:48 PST
Created attachment 383748 [details]
Patch
Comment 10 Alexey Proskuryakov 2019-11-18 09:46:14 PST
Comment on attachment 383748 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=383748&action=review

> LayoutTests/ChangeLog:12
> +        Speculative fixes:

This is failing EWS
Comment 11 Chris Dumez 2019-11-18 11:22:04 PST
Comment on attachment 383748 [details]
Patch

Will investigate.
Comment 12 Chris Dumez 2019-11-18 14:49:01 PST
(In reply to Chris Dumez from comment #11)
> Comment on attachment 383748 [details]
> Patch
> 
> Will investigate.

Very odd, this test is passing for me locally on Mac-wk2.
Comment 13 Chris Dumez 2019-11-18 16:24:55 PST
Created attachment 383804 [details]
Patch
Comment 14 Chris Dumez 2019-11-19 09:37:19 PST
I cannot reproduce it locally but it looks like caches.open() flakily times out on the iOS wk2 and macOS wk2 bots for some reason.
Comment 15 Chris Dumez 2019-11-19 10:16:17 PST
Created attachment 383878 [details]
Patch
Comment 16 Chris Dumez 2019-11-21 12:27:40 PST
Ping review? EWS was able to reproduce the flakiness previously so it looks like this did the trick.
Comment 17 Aakash Jain 2019-11-22 04:28:08 PST
This is slowing down EWS sometimes.

e.g.: In https://ews-build.webkit.org/#/builders/24/builds/5353 this test failed while running layout-tests, and EWS had to re-run layout-tests in which it passed. If the test wasn't flaky, the re-run wouldn't have been required.
Comment 18 WebKit Commit Bot 2019-11-22 05:29:04 PST
Comment on attachment 383878 [details]
Patch

Clearing flags on attachment: 383878

Committed r252769: <https://trac.webkit.org/changeset/252769>
Comment 19 WebKit Commit Bot 2019-11-22 05:29:06 PST
All reviewed patches have been landed.  Closing bug.