Bug 20337 – Implement CSS Animation and Transition Events

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Dean Jackson]

Need to implement the Event interfaces for CSS Animations and Transitions

http://webkit.org/specs

[Dean Jackson]

Created attachment 22709 [details]
in progress patch

Still need to link up dom stuff. Won't build on non-mac platforms.

[Dean Jackson]

Created attachment 22710 [details]
updated patch

still won't build on non-OSX

[Dean Jackson]

Created attachment 22711 [details]
working patch, with a test/example

Just need to fix other platforms build.

[Dean Jackson]

Created attachment 22712 [details]
now ready for review

Now should build on all platforms.

[Timothy Hatcher]

Comment on attachment 22712 [details]
now ready for review

+    if (eventType == EventNames::webkitTransitionEndEvent) {
+        element->dispatchWebKitTransitionEvent(eventType, name, elapsedTime);
+    } 
+    else {
+        element->dispatchWebKitAnimationEvent(eventType, name, elapsedTime);
+    }

The braces should be removed here.

Otherwise looks good, and Hyatt looked over it earlier.

[Dean Jackson]

Modified after review comments.

Committed r35666
	M	WebCore/GNUmakefile.am
	M	WebCore/bindings/js/JSEventCustom.cpp
	M	WebCore/bindings/js/JSDOMWindowBase.h
	M	WebCore/bindings/js/JSDOMWindowBase.cpp
	M	WebCore/DerivedSources.make
	M	WebCore/html/HTMLElement.cpp
	M	WebCore/html/HTMLAttributeNames.in
	A	WebCore/manual-tests/transition-events.html
	M	WebCore/dom/Event.cpp
	A	WebCore/dom/WebKitAnimationEvent.h
	M	WebCore/dom/EventTargetNode.cpp
	A	WebCore/dom/WebKitAnimationEvent.idl
	M	WebCore/dom/Document.h
	A	WebCore/dom/WebKitAnimationEvent.cpp
	M	WebCore/dom/EventTargetNode.h
	M	WebCore/dom/Event.h
	A	WebCore/dom/WebKitTransitionEvent.idl
	A	WebCore/dom/WebKitTransitionEvent.cpp
	M	WebCore/dom/EventTarget.cpp
	A	WebCore/dom/WebKitTransitionEvent.h
	M	WebCore/WebCore.xcodeproj/project.pbxproj
	M	WebCore/WebCore.pro
	M	WebCore/ChangeLog
	M	WebCore/WebCore.vcproj/WebCore.vcproj
	M	WebCore/WebCoreSources.bkl
	M	WebCore/page/AnimationController.cpp