Bug 20337 - Implement CSS Animation and Transition Events
Summary: Implement CSS Animation and Transition Events
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Macintosh OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-08-08 14:21 PDT by Dean Jackson
Modified: 2008-08-11 10:25 PDT (History)
2 users (show)

See Also:


Attachments
in progress patch (18.46 KB, patch)
2008-08-08 14:23 PDT, Dean Jackson
no flags Details | Formatted Diff | Diff
updated patch (37.87 KB, patch)
2008-08-08 14:47 PDT, Dean Jackson
no flags Details | Formatted Diff | Diff
working patch, with a test/example (43.23 KB, patch)
2008-08-08 15:17 PDT, Dean Jackson
no flags Details | Formatted Diff | Diff
now ready for review (47.35 KB, patch)
2008-08-08 15:26 PDT, Dean Jackson
timothy: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dean Jackson 2008-08-08 14:21:16 PDT
Need to implement the Event interfaces for CSS Animations and Transitions

http://webkit.org/specs
Comment 1 Dean Jackson 2008-08-08 14:23:11 PDT
Created attachment 22709 [details]
in progress patch

Still need to link up dom stuff. Won't build on non-mac platforms.
Comment 2 Dean Jackson 2008-08-08 14:47:23 PDT
Created attachment 22710 [details]
updated patch

still won't build on non-OSX
Comment 3 Dean Jackson 2008-08-08 15:17:33 PDT
Created attachment 22711 [details]
working patch, with a test/example

Just need to fix other platforms build.
Comment 4 Dean Jackson 2008-08-08 15:26:02 PDT
Created attachment 22712 [details]
now ready for review

Now should build on all platforms.
Comment 5 Timothy Hatcher 2008-08-08 20:48:32 PDT
Comment on attachment 22712 [details]
now ready for review

+    if (eventType == EventNames::webkitTransitionEndEvent) {
+        element->dispatchWebKitTransitionEvent(eventType, name, elapsedTime);
+    } 
+    else {
+        element->dispatchWebKitAnimationEvent(eventType, name, elapsedTime);
+    }

The braces should be removed here.

Otherwise looks good, and Hyatt looked over it earlier.
Comment 6 Dean Jackson 2008-08-11 10:25:12 PDT
Modified after review comments.

Committed r35666
	M	WebCore/GNUmakefile.am
	M	WebCore/bindings/js/JSEventCustom.cpp
	M	WebCore/bindings/js/JSDOMWindowBase.h
	M	WebCore/bindings/js/JSDOMWindowBase.cpp
	M	WebCore/DerivedSources.make
	M	WebCore/html/HTMLElement.cpp
	M	WebCore/html/HTMLAttributeNames.in
	A	WebCore/manual-tests/transition-events.html
	M	WebCore/dom/Event.cpp
	A	WebCore/dom/WebKitAnimationEvent.h
	M	WebCore/dom/EventTargetNode.cpp
	A	WebCore/dom/WebKitAnimationEvent.idl
	M	WebCore/dom/Document.h
	A	WebCore/dom/WebKitAnimationEvent.cpp
	M	WebCore/dom/EventTargetNode.h
	M	WebCore/dom/Event.h
	A	WebCore/dom/WebKitTransitionEvent.idl
	A	WebCore/dom/WebKitTransitionEvent.cpp
	M	WebCore/dom/EventTarget.cpp
	A	WebCore/dom/WebKitTransitionEvent.h
	M	WebCore/WebCore.xcodeproj/project.pbxproj
	M	WebCore/WebCore.pro
	M	WebCore/ChangeLog
	M	WebCore/WebCore.vcproj/WebCore.vcproj
	M	WebCore/WebCoreSources.bkl
	M	WebCore/page/AnimationController.cpp