RESOLVED FIXED 203367
[iOS] Mismatch in com.apple.coremedia.audiodeviceclock declarations
https://bugs.webkit.org/show_bug.cgi?id=203367
Summary [iOS] Mismatch in com.apple.coremedia.audiodeviceclock declarations
Brent Fulgham
Reported 2019-10-24 09:01:15 PDT
The 'common.sb' sandbox allows access to "com.apple.coremedia.audiodeviceclock.xpc", but our WebContent sandbox blocked access to "com.apple.coremedia.audiodeviceclock". This means we aren't blocking that endpoint.
Attachments
Patch (2.15 KB, patch)
2019-10-24 13:10 PDT, Brent Fulgham
no flags
Patch for landing (2.19 KB, patch)
2019-10-24 14:54 PDT, Brent Fulgham
no flags
Radar WebKit Bug Importer
Comment 1 2019-10-24 09:03:55 PDT
Brent Fulgham
Comment 2 2019-10-24 13:10:30 PDT
Brent Fulgham
Comment 3 2019-10-24 13:17:35 PDT
This doesn't seem to create sandbox violations when playing media or testing WebAudio APIs on an iPad. It looks like we were indeed not using the endpoint.
Per Arne Vollan
Comment 4 2019-10-24 13:46:21 PDT
Comment on attachment 381835 [details] Patch R=me.
WebKit Commit Bot
Comment 5 2019-10-24 14:51:25 PDT
Comment on attachment 381835 [details] Patch Rejecting attachment 381835 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 381835, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Logging in as commit-queue@webkit.org... Fetching: https://bugs.webkit.org/attachment.cgi?id=381835&action=edit Fetching: https://bugs.webkit.org/show_bug.cgi?id=203367&ctype=xml&excludefield=attachmentdata Processing 1 patch from 1 bug. Updating working directory Processing patch 381835 from bug 203367. Fetching: https://bugs.webkit.org/attachment.cgi?id=381835 Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Per Arne Vollan']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Parsed 2 diffs from patch file(s). patching file Source/WebKit/ChangeLog Hunk #1 succeeded at 1 with fuzz 1. patching file Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb Hunk #2 FAILED at 916. 1 out of 2 hunks FAILED -- saving rejects to file Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.rej Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Per Arne Vollan']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Parsed 2 diffs from patch file(s). patching file Source/WebKit/ChangeLog Hunk #1 succeeded at 1 with fuzz 1. patching file Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb Hunk #2 FAILED at 916. 1 out of 2 hunks FAILED -- saving rejects to file Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.rej Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Per Arne Vollan']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Updating OpenSource From https://git.webkit.org/git/WebKit 7f987489098..256585f1cac master -> origin/master Partial-rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ... Currently at 251558 = 7f9874890985133e41b8596da57b25ed06c3cdf0 r251559 = 3cdb05fccf94adb8cfcfd25febceff232ac0d232 r251560 = fd284dd1a208a430c610bee1ed0713ae2d0a888f r251561 = 4ea555eab15661e7aeae9dbcf4156735714844d6 r251562 = d799dc09249e2105a640048bd1c8423ee8cfabd7 r251563 = 256585f1cacb1d9d03b5c903819259c225e9936a Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/origin/master. Full output: https://webkit-queues.webkit.org/results/13174606
Brent Fulgham
Comment 6 2019-10-24 14:54:56 PDT
Created attachment 381845 [details] Patch for landing
WebKit Commit Bot
Comment 7 2019-10-24 15:14:08 PDT
Comment on attachment 381845 [details] Patch for landing Clearing flags on attachment: 381845 Committed r251566: <https://trac.webkit.org/changeset/251566>
WebKit Commit Bot
Comment 8 2019-10-24 15:14:09 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.