Bug 203359 – export-w3c-test-changes should add the "webkit-exports" label in GitHub

• Status: NEW
• Component: Tools / Tests

[Simon Pieters (:zcorpan)]

See https://github.com/web-platform-tests/wpt-pr-bot/pull/63#discussion_r256135694

The @wpt-pr-bot bot currently checks the PR title and the username to decide if a PR is a WebKit export.
Checking the "webkit-exports" label instead would be better, but it's not automatically added currently.

Labels can only be set by users with write access to wpt, so either the WebKit contributor needs to have that, or there should be a WebKit wpt export bot user similar to @chromium-wpt-export-bot, @servo-wpt-sync, @moz-wptsync-bot.

Related: https://github.com/web-platform-tests/wpt/issues/19796

[Philip Jägenstedt]

Also related: https://github.com/web-platform-tests/wpt-pr-bot/issues/100

[Pablo Saavedra]

According with https://bugs.webkit.org/show_bug.cgi?id=183575, the test_exporter.py is already using the 'webkit-export' label:

   WEBKIT_EXPORT_PR_LABEL = 'webkit-export'

... but apparently this label is still missing in the PR pushed with the `Scripts/export-w3c-test-changes` command.

[Pablo Saavedra]

the script uses `add_label` from webkitpy/w3c/wpt_github.py to set the label for the PR:


```
    def add_label(self, number, label):
        """Adds a label to a GitHub issue (or PR).

        API doc: https://developer.github.com/v3/issues/labels/#add-labels-to-an-issue
        """
        path = '/repos/%s/%s/issues/%d/labels' % (
            WPT_GH_ORG,
            WPT_GH_REPO_NAME,
            number
        )
        body = [label]
        response = self.request(path, method='POST', body=body)
```


the function is sending the labels as a list of one single string but note that this Github API is expecting a JSON document (https://developer.github.com/v3/issues/labels/#example-2):

{
  "labels": ["bug", "enhancement"]
}

[Pablo Saavedra]

(In reply to Pablo Saavedra from comment #3)
> the script uses `add_label` from webkitpy/w3c/wpt_github.py to set the label
> for the PR:
> 
> 
> ```
>     def add_label(self, number, label):
>         """Adds a label to a GitHub issue (or PR).
> 
>         API doc:
> https://developer.github.com/v3/issues/labels/#add-labels-to-an-issue
>         """
>         path = '/repos/%s/%s/issues/%d/labels' % (
>             WPT_GH_ORG,
>             WPT_GH_REPO_NAME,
>             number
>         )
>         body = [label]
>         response = self.request(path, method='POST', body=body)
> ```
> 
> 
> the function is sending the labels as a list of one single string but note
> that this Github API is expecting a JSON document
> (https://developer.github.com/v3/issues/labels/#example-2):
> 
> {
>   "labels": ["bug", "enhancement"]
> }

This must be confirmed. Maybe the other one is working as well despite not being part the documentation.