Bug 203348 - [Cocoa] Make it possible to convert SharedBuffer segments and data views to NSData without copying
Summary: [Cocoa] Make it possible to convert SharedBuffer segments and data views to N...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andy Estes
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-10-23 16:34 PDT by Andy Estes
Modified: 2019-10-24 12:40 PDT (History)
7 users (show)

See Also:


Attachments
Patch (8.01 KB, patch)
2019-10-23 16:41 PDT, Andy Estes
no flags Details | Formatted Diff | Diff
Patch (8.89 KB, patch)
2019-10-23 19:44 PDT, Andy Estes
no flags Details | Formatted Diff | Diff
Patch (8.91 KB, patch)
2019-10-23 21:04 PDT, Andy Estes
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews211 for win-future (13.93 MB, application/zip)
2019-10-24 07:08 PDT, EWS Watchlist
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Andy Estes 2019-10-23 16:34:32 PDT
[Cocoa] Make it possible to convert SharedBuffer segments and data views to NSData without copying
Comment 1 Andy Estes 2019-10-23 16:41:53 PDT
Created attachment 381753 [details]
Patch
Comment 2 Andy Estes 2019-10-23 19:44:47 PDT
Created attachment 381768 [details]
Patch
Comment 3 Andy Estes 2019-10-23 21:04:30 PDT
Created attachment 381772 [details]
Patch
Comment 4 EWS Watchlist 2019-10-24 07:08:07 PDT
Comment on attachment 381772 [details]
Patch

Attachment 381772 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/13173682

New failing tests:
fast/repaint/backgroundSizeRepaint.html
Comment 5 EWS Watchlist 2019-10-24 07:08:09 PDT
Created attachment 381806 [details]
Archive of layout-test-results from ews211 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews211  Port: win-future  Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit
Comment 6 Andy Estes 2019-10-24 10:09:22 PDT
(In reply to Build Bot from comment #4)
> Comment on attachment 381772 [details]
> Patch
> 
> Attachment 381772 [details] did not pass win-ews (win):
> Output: https://webkit-queues.webkit.org/results/13173682
> 
> New failing tests:
> fast/repaint/backgroundSizeRepaint.html

win-ews ran this test four times with my patch and it failed 2/4 times, so I think this is just flakiness.
Comment 7 WebKit Commit Bot 2019-10-24 10:51:41 PDT
Comment on attachment 381772 [details]
Patch

Clearing flags on attachment: 381772

Committed r251546: <https://trac.webkit.org/changeset/251546>
Comment 8 WebKit Commit Bot 2019-10-24 10:51:47 PDT
All reviewed patches have been landed.  Closing bug.
Comment 9 Radar WebKit Bug Importer 2019-10-24 12:40:30 PDT
<rdar://problem/56590051>