Bug 203344 - Drop support for NSURLCache callbacks in NetworkProcess
Summary: Drop support for NSURLCache callbacks in NetworkProcess
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ben Nham
URL:
Keywords: InRadar
Depends on: 205074
Blocks:
  Show dependency treegraph
 
Reported: 2019-10-23 15:26 PDT by Ben Nham
Modified: 2019-12-17 13:23 PST (History)
7 users (show)

See Also:


Attachments
Patch (2.35 KB, patch)
2019-11-18 10:17 PST, Ben Nham
no flags Details | Formatted Diff | Diff
Patch (2.38 KB, patch)
2019-12-06 09:54 PST, Ben Nham
no flags Details | Formatted Diff | Diff
Patch (2.35 KB, patch)
2019-12-16 12:51 PST, Ben Nham
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ben Nham 2019-10-23 15:26:46 PDT
Since we dropped support for NSURLCache in NetworkProcess in https://bugs.webkit.org/show_bug.cgi?id=185990, it seems like we should also be able to remove our implementation of the -[WKNetworkSessionDelegate URLSession:dataTask:willCacheResponse:completionHandler:] callback.
Comment 1 Ben Nham 2019-11-18 10:17:06 PST
Created attachment 383756 [details]
Patch
Comment 2 WebKit Commit Bot 2019-11-18 14:42:38 PST
Comment on attachment 383756 [details]
Patch

Rejecting attachment 383756 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 383756, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in Source/WebKit/ChangeLog contains OOPS!.

Full output: https://webkit-queues.webkit.org/results/13265086
Comment 3 Ben Nham 2019-12-06 09:54:49 PST
Created attachment 385023 [details]
Patch
Comment 4 Ben Nham 2019-12-06 09:55:52 PST
Comment on attachment 385023 [details]
Patch

Same as previous reviewed patch, but has the "Reviewed by" field filled out to please the commit queue.
Comment 5 WebKit Commit Bot 2019-12-06 13:03:58 PST
Comment on attachment 385023 [details]
Patch

Clearing flags on attachment: 385023

Committed r253212: <https://trac.webkit.org/changeset/253212>
Comment 6 WebKit Commit Bot 2019-12-06 13:04:00 PST
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2019-12-06 13:04:18 PST
<rdar://problem/57710222>
Comment 8 WebKit Commit Bot 2019-12-10 12:06:37 PST
Re-opened since this is blocked by bug 205074
Comment 9 Alexey Proskuryakov 2019-12-10 15:27:48 PST
Can the be re-landed now?
Comment 10 Ben Nham 2019-12-16 12:51:59 PST
Created attachment 385799 [details]
Patch
Comment 11 Ben Nham 2019-12-16 12:52:49 PST
Comment on attachment 385799 [details]
Patch

Re-submitting patch for review and commit queue since the original was rolled back incorrectly (it did not cause 205074 as originally reported).
Comment 12 WebKit Commit Bot 2019-12-17 13:23:02 PST
Comment on attachment 385799 [details]
Patch

Clearing flags on attachment: 385799

Committed r253642: <https://trac.webkit.org/changeset/253642>
Comment 13 WebKit Commit Bot 2019-12-17 13:23:04 PST
All reviewed patches have been landed.  Closing bug.