Bug 203339 - Undo incidental change from BytecodeIndex class patch
Summary: Undo incidental change from BytecodeIndex class patch
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keith Miller
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-10-23 14:47 PDT by Keith Miller
Modified: 2019-10-23 20:09 PDT (History)
7 users (show)

See Also:

Attachments
Patch (2.79 KB, patch)
2019-10-23 14:54 PDT, Keith Miller 		no flags Details | Formatted Diff | Diff
Patch (2.80 KB, patch)
2019-10-23 15:11 PDT, Keith Miller 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Miller 2019-10-23 14:47:27 PDT 
Undo incidental change from BytecodeIndex class patch
Comment 1 Keith Miller 2019-10-23 14:54:12 PDT 
Created attachment 381733 [details]
Patch
Comment 2 Keith Miller 2019-10-23 14:54:59 PDT 
rdar://problem/56529630
Comment 3 Mark Lam 2019-10-23 15:09:00 PDT 
Comment on attachment 381733 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=381733&action=review

> Source/JavaScriptCore/ChangeLog:11
> +        It's not totally clear why we need to claim our bytecode index is
> +we can't figure what the true index is. I'd rather unbreak
> +        our build for now, however, and fix the underlying issue in
> +        https://bugs.webkit.org/show_bug.cgi?id=203340

Can you fix this?
Comment 4 Keith Miller 2019-10-23 15:10:54 PDT 
Comment on attachment 381733 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=381733&action=review

>> Source/JavaScriptCore/ChangeLog:11
>> +        https://bugs.webkit.org/show_bug.cgi?id=203340
> 
> Can you fix this?

Woah, weird. Sure.
Comment 5 Keith Miller 2019-10-23 15:11:00 PDT 
Created attachment 381736 [details]
Patch
Comment 6 Mark Lam 2019-10-23 15:14:12 PDT 
Comment on attachment 381736 [details]
Patch

r=me if JSC tests are green.
Comment 7 WebKit Commit Bot 2019-10-23 20:09:20 PDT 
Comment on attachment 381736 [details]
Patch

Clearing flags on attachment: 381736

Committed r251525: <https://trac.webkit.org/changeset/251525>
Comment 8 WebKit Commit Bot 2019-10-23 20:09:30 PDT 
All reviewed patches have been landed.  Closing bug.