Bug 203318 - [iOS] Stop including 'common.sb'
Summary: [iOS] Stop including 'common.sb'
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brent Fulgham
URL:
Keywords: InRadar
Depends on:
Blocks: 203352
  Show dependency tree / graph
 
Reported: 2019-10-23 14:10 PDT by Brent Fulgham
Modified: 2019-10-24 13:28 PDT (History)
5 users (show)

See Also:

Attachments
Patch (22.55 KB, patch)
2019-10-23 14:19 PDT, Brent Fulgham 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2019-10-23 14:10:47 PDT 
The 'common.sb' sandbox file activates many features we do not need in the WebContent process. We should pare down the allowed items.

This patch is the first step, which replaces the '(import "common.sb")' with a copy/paste of the contents of the sandbox profile.

I also removed anything that was explicitly blocked in a later line of the sandbox, but wanted to minimize changes as much as possible in this first step.
Comment 1 Brent Fulgham 2019-10-23 14:11:23 PDT 
<rdar://problem/56374092>
Comment 2 Brent Fulgham 2019-10-23 14:19:46 PDT 
Created attachment 381726 [details]
Patch
Comment 3 Per Arne Vollan 2019-10-23 15:22:28 PDT 
Comment on attachment 381726 [details]
Patch

Great! R=me.
Comment 4 WebKit Commit Bot 2019-10-23 17:02:32 PDT 
Comment on attachment 381726 [details]
Patch

Clearing flags on attachment: 381726

Committed r251511: <https://trac.webkit.org/changeset/251511>
Comment 5 WebKit Commit Bot 2019-10-23 17:02:33 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Brent Fulgham 2019-10-24 13:28:18 PDT 
Note: The following fix was also needed:
<https://trac.webkit.org/changeset/251555/webkit>