[ iOS ]: Layout Test http/tests/IndexedDB/storage-limit-1.https.html is a Flaky Failure

[Russell Epstein]

The following layout test is a flaky failure across all iOS configurations:

http/tests/IndexedDB/storage-limit-1.https.html 

Diff:

--- /Volumes/Data/slave/ios-simulator-13-release-tests-wk2/build/layout-test-results/http/tests/IndexedDB/storage-limit-1.https-expected.txt
+++ /Volumes/Data/slave/ios-simulator-13-release-tests-wk2/build/layout-test-results/http/tests/IndexedDB/storage-limit-1.https-actual.txt
@@ -12,10 +12,9 @@
 db = event.target.result
 store = db.transaction('store', 'readwrite').objectStore('store')
 request = store.add(new Uint8Array(300 * 1024), 'key')
-PASS 'error' in request is true
-PASS request.error.code is DOMException.QUOTA_EXCEEDED_ERR
-PASS request.error.name is "QuotaExceededError"
+FAIL Add operation should fail because storage limit is reached, but succeeded.
 PASS successfullyParsed is true
+Some tests failed.
 
 TEST COMPLETE

[Radar WebKit Bug Importer]

<rdar://problem/56516249>

[Russell Epstein]

Test History:

https://results.webkit.org/?suite=layout-tests&test=http%2Ftests%2FIndexedDB%2Fstorage-limit-1.https.html&platform=ios

[Sihui Liu]

(In reply to Russell Epstein from comment #0)
> The following layout test is a flaky failure across all iOS configurations:
> 
> http/tests/IndexedDB/storage-limit-1.https.html 
> 
> Diff:
> 
> ---
> /Volumes/Data/slave/ios-simulator-13-release-tests-wk2/build/layout-test-
> results/http/tests/IndexedDB/storage-limit-1.https-expected.txt
> +++
> /Volumes/Data/slave/ios-simulator-13-release-tests-wk2/build/layout-test-
> results/http/tests/IndexedDB/storage-limit-1.https-actual.txt
> @@ -12,10 +12,9 @@
>  db = event.target.result
>  store = db.transaction('store', 'readwrite').objectStore('store')
>  request = store.add(new Uint8Array(300 * 1024), 'key')
> -PASS 'error' in request is true
> -PASS request.error.code is DOMException.QUOTA_EXCEEDED_ERR
> -PASS request.error.name is "QuotaExceededError"
> +FAIL Add operation should fail because storage limit is reached, but
> succeeded.
>  PASS successfullyParsed is true
> +Some tests failed.
>  
>  TEST COMPLETE

Can you reproduce on local build?

[Russell Epstein]

(In reply to Sihui Liu from comment #3)
> Can you reproduce on local build?

So far I have been unsuccessful in locally reproducing this failure.

[Russell Epstein]

Updated TestExpectations in r251505.

[youenn fablet]

Created attachment 383398 [details]
Patch

[Alex Christensen]

Comment on attachment 383398 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=383398&action=review

> Source/WebKit/NetworkProcess/cache/CacheStorageEngine.cpp:62
> +    auto pendingClearCallbacks = WTFMove(m_pendingClearCallbacks);

I feel like this should be std::exchange, but I guess it's not too big of a deal because this is in the destructor.

[youenn fablet]

(In reply to Alex Christensen from comment #7)
> Comment on attachment 383398 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=383398&action=review
> 
> > Source/WebKit/NetworkProcess/cache/CacheStorageEngine.cpp:62
> > +    auto pendingClearCallbacks = WTFMove(m_pendingClearCallbacks);
> 
> I feel like this should be std::exchange, but I guess it's not too big of a
> deal because this is in the destructor.

It is a Vector so it is equivalent and the destructor is using the same pattern.

[WebKit Commit Bot]

Comment on attachment 383398 [details]
Patch

Clearing flags on attachment: 383398

Committed r252412: <https://trac.webkit.org/changeset/252412>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[youenn fablet]

*** Bug 204121 has been marked as a duplicate of this bug. ***