Bug 203274 - Make `JSGlobalObject*` threading change more stabilized by adding tests and assertions
Summary: Make `JSGlobalObject*` threading change more stabilized by adding tests and a...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on: 202392
Blocks:
  Show dependency tree / graph
 
Reported: 2019-10-22 14:35 PDT by Yusuke Suzuki
Modified: 2019-10-22 22:16 PDT (History)
11 users (show)

See Also:

Attachments
Patch (6.32 KB, patch)
2019-10-22 18:19 PDT, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Patch (6.35 KB, patch)
2019-10-22 18:21 PDT, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Patch (6.67 KB, patch)
2019-10-22 18:32 PDT, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Patch (8.72 KB, patch)
2019-10-22 20:18 PDT, Yusuke Suzuki 		saam: review+
Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2019-10-22 14:35:04 PDT 
Follow-up after r251425
Comment 1 Yusuke Suzuki 2019-10-22 18:19:55 PDT 
Created attachment 381641 [details]
Patch
Comment 2 Yusuke Suzuki 2019-10-22 18:21:54 PDT 
Created attachment 381642 [details]
Patch
Comment 3 Yusuke Suzuki 2019-10-22 18:28:28 PDT 
Comment on attachment 381642 [details]
Patch

Checking.
Comment 4 Yusuke Suzuki 2019-10-22 18:32:51 PDT 
Created attachment 381643 [details]
Patch
Comment 5 Yusuke Suzuki 2019-10-22 20:18:07 PDT 
Created attachment 381648 [details]
Patch
Comment 6 Radar WebKit Bug Importer 2019-10-22 20:21:14 PDT 
<rdar://problem/56526714>
Comment 7 Saam Barati 2019-10-22 21:39:20 PDT 
Comment on attachment 381648 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=381648&action=review

> Source/JavaScriptCore/ChangeLog:10
> +        1. Add tests that touches vm.topCallFrame from C++ world.

“touches” => “tests”
And maybe say that you’re testing that it remains null
Comment 8 Yusuke Suzuki 2019-10-22 22:16:00 PDT 
Comment on attachment 381648 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=381648&action=review

I've checked that debug layout-test finishes without assertion hit in EWS. I'll land this :)

>> Source/JavaScriptCore/ChangeLog:10
>> +        1. Add tests that touches vm.topCallFrame from C++ world.
> 
> “touches” => “tests”
> And maybe say that you’re testing that it remains null

Fixed.
Comment 9 Yusuke Suzuki 2019-10-22 22:16:56 PDT 
Committed r251475: <https://trac.webkit.org/changeset/251475>