Refactor "builds" table "builder_number" row to "build_serial" to fit more generic use cases.
Created attachment 381599 [details] Patch
Comment on attachment 381599 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=381599&action=review > Websites/perf.webkit.org/init-database.sql:79 > + build_serial varchar(64) NOT NULL, Not sure serial is a good name for this since non-numeric identifier isn’t in “series”. Maybe we can keep “number” and just change the type. Or perhaps “revision” since we use that for commits as well.
Created attachment 381633 [details] Patch
Comment on attachment 381633 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=381633&action=review > Websites/perf.webkit.org/public/api/upload-root.php:14 > + exit_with_error('ShouldNotHaveBothBuildNumberAndBuildTag', array('buildNumber' => $_POST['buildNumber'], 'buildTag' => $_POST['buildTag'])); This is a lengthly error message. Also, it seems fine if we specified both & both are identical during the transition period. Why not check the values? and return BuilderNumberTagMismatch in the case they're not equal. > Websites/perf.webkit.org/public/include/report-processor.php:110 > + if (array_key_exists('buildNumber', $report)) { > + if (array_key_exists('buildTag', $report)) Ditto about allowing both if they're identical.
Note: we may want to add a guide on how to upgrade perf dashboard to a new version to ReadMe.md saying we want to run the migration sql file and then also clearing the cache directory.
Landed in r251564.
<rdar://problem/56635615>