Bug 203260 - [JSC] Remove non-LargeAllocation restriction for JSCallee
Summary: [JSC] Remove non-LargeAllocation restriction for JSCallee
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks: 203282
  Show dependency tree / graph
 
Reported: 2019-10-22 11:46 PDT by Yusuke Suzuki
Modified: 2019-10-22 18:25 PDT (History)
13 users (show)

See Also:

Attachments
Patch (3.36 KB, patch)
2019-10-22 11:47 PDT, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Patch (59.98 KB, patch)
2019-10-22 14:11 PDT, Yusuke Suzuki 		saam: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2019-10-22 11:46:31 PDT 
[JSC] Remove non-LargeAllocation restriction for JSCallee
Comment 1 Yusuke Suzuki 2019-10-22 11:47:54 PDT 
Created attachment 381574 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2019-10-22 11:48:15 PDT 
<rdar://problem/56508915>
Comment 3 Yusuke Suzuki 2019-10-22 11:57:48 PDT 
Comment on attachment 381574 [details]
Patch

compile errors. Fix it later
Comment 4 Yusuke Suzuki 2019-10-22 14:11:06 PDT 
Created attachment 381600 [details]
Patch
Comment 5 Saam Barati 2019-10-22 14:20:44 PDT 
Comment on attachment 381600 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=381600&action=review

> Source/JavaScriptCore/ChangeLog:12
> +        This patch renames `CallFrame::vm` to `CallFrame::deprecatedVM`. And we avoid using it as much as possible.

can we file a bug on doing refactoring necessary to delete this function?
Comment 6 Yusuke Suzuki 2019-10-22 14:21:30 PDT 
Comment on attachment 381600 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=381600&action=review

>> Source/JavaScriptCore/ChangeLog:12
>> +        This patch renames `CallFrame::vm` to `CallFrame::deprecatedVM`. And we avoid using it as much as possible.
> 
> can we file a bug on doing refactoring necessary to delete this function?

Filed, https://bugs.webkit.org/show_bug.cgi?id=203272 thanks!
Comment 7 Yusuke Suzuki 2019-10-22 14:23:32 PDT 
Committed r251457: <https://trac.webkit.org/changeset/251457>
Comment 8 Mark Lam 2019-10-22 14:30:30 PDT 
Comment on attachment 381600 [details]
Patch

r=me too.  Since you're modifying CodeGeneratorJS.pm, you need to rebase the binding test results.
Comment 9 Mark Lam 2019-10-22 15:13:04 PDT 
(In reply to Mark Lam from comment #8)
> Comment on attachment 381600 [details]
> Patch
> 
> r=me too.  Since you're modifying CodeGeneratorJS.pm, you need to rebase the
> binding test results.

I realized afterwards that the bindings tests are passing on the EWS.  So, maybe this change is not covered by the tests and no rebasing or results needed.