Bug 20325 - Can't insert text between non-editable SPAN inside a contenteditable DIV
Summary: Can't insert text between non-editable SPAN inside a contenteditable DIV
Status: RESOLVED DUPLICATE of bug 31750
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: 528+ (Nightly build)
Hardware: All OS X 10.5
: P2 Normal
Assignee: Enrica Casucci
Keywords: InRadar
Depends on:
Reported: 2008-08-07 16:55 PDT by Robbie Paplin
Modified: 2009-11-30 16:48 PST (History)
6 users (show)

See Also:

Test case that shows you can't place caret between non-editable SPAN elements in a contenteditable DIV (1.79 KB, text/html)
2008-08-07 16:57 PDT, Robbie Paplin
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Robbie Paplin 2008-08-07 16:55:00 PDT
The attached page has a DIV with a contenteditable = true attribute. The DIV contains SPAN elements with a contenteditable = false attribute. When I attempt to place the caret between the SPAN elements, the browser does not let me place the caret between the SPAN elements or insert text between them (even though the space between the SPAN elements is editable.
Comment 1 Robbie Paplin 2008-08-07 16:57:56 PDT
Created attachment 22702 [details]
Test case that shows you can't place caret between non-editable SPAN elements in a contenteditable DIV
Comment 2 Mark Rowe (bdash) 2008-08-07 19:58:16 PDT
Comment 3 Ryosuke Niwa 2009-07-22 01:00:22 PDT
This bug might be related to the bug 19698, which says we can't add text before or after span with contenteditable="false" when it is the only child node in a div with contenteditable="true".
Comment 4 webkit 2009-11-21 14:58:49 PST
I have been playing around with this bug for the last few days. This is my first WebKit endeavor so please forgive my ignorance :p. Sorry if I'm too verbose here.

The selection/caret has to be linked to a text node of the editable parent (otherwise where are the characters gonna go when you type?). If we have two adjacent non-editable nodes inside an editable parent, then it is impossible for text to be inserted between the nodes unless a text node exists there first.

The solution it seems, would be to have WebKit insert empty text nodes in these places. I tried simulating this with JavaScript, but WebKit skips over empty nodes. I have isolated the code that does this and have managed to fix the problem:

When you move the caret with the right arrow key, WebKit calls Position::isCandidate on each node after the current position until it returns true. isCandidate will fail on non-editable nodes and empty text nodes, causing the caret to skip over them.
You can make empty text nodes valid candidates by ensuring Position::inRenderedText() returns true:

bool Position::inRenderedText() const
  return true;

Note: this should not blindly return true. There needs to be additional logic here.

Now that the caret can move inside empty text nodes, we can stop <br/> tags from getting (annoyingly) inserted whenever a text node is removed.

void DeleteSelectionCommand::doApply()
  RefPtr<Node> placeholder = m_needPlaceholder ? document()->createTextNode("") : 0;

Note that these fixes do not solve the problem or make the above testcase pass. WebKit needs to insert empty text nodes between the non-editable nodes. I have not yet figured out how to do this without using js.
Comment 5 Enrica Casucci 2009-11-30 10:04:49 PST
This bug is the same as https://bugs.webkit.org/show_bug.cgi?id=31750.
I posted a patch last week and I'm waiting for it to be reviewed.
Comment 6 Enrica Casucci 2009-11-30 16:48:23 PST
Committed revision 51522. This was the same as https://bugs.webkit.org/show_bug.cgi?id=31750

*** This bug has been marked as a duplicate of bug 31750 ***