Bug 203244 - [GTK][WPE] Fix non-unified builds after r251326
Summary: [GTK][WPE] Fix non-unified builds after r251326
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adrian Perez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-10-22 05:40 PDT by Adrian Perez
Modified: 2019-10-22 09:40 PDT (History)
25 users (show)

See Also:

Attachments
Patch (12.80 KB, patch)
2019-10-22 06:23 PDT, Adrian Perez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adrian Perez 2019-10-22 05:40:08 PDT 
Another weekly batch of fixups for non-unified builds :-}
Comment 1 Adrian Perez 2019-10-22 06:23:34 PDT 
Created attachment 381539 [details]
Patch
Comment 2 youenn fablet 2019-10-22 06:27:04 PDT 
Comment on attachment 381539 [details]
Patch

r=me once bots are happy.
It would be great to have an EWS bot building non unified.
Comment 3 Adrian Perez 2019-10-22 08:10:27 PDT 
(In reply to youenn fablet from comment #2)
> Comment on attachment 381539 [details]
> Patch
> 
> r=me once bots are happy.

The “ios-wk2” test which fails is not new, it has been there for a
few builds; same for the flaky ones. The issue with the “wincairo”
build is the intermittent failure to clean up temporary files at the
time of applying the patch.

It looks safe to cq+ this :)

> It would be great to have an EWS bot building non unified.

Agreed. Let's see if I can manage to “borrow“ some time from something
else in the coming weeks for that.
Comment 4 WebKit Commit Bot 2019-10-22 09:39:04 PDT 
Comment on attachment 381539 [details]
Patch

Clearing flags on attachment: 381539

Committed r251436: <https://trac.webkit.org/changeset/251436>
Comment 5 WebKit Commit Bot 2019-10-22 09:39:06 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2019-10-22 09:40:18 PDT 
<rdar://problem/56502978>