RESOLVED FIXED 203226
Add a script to run ImageDiff manually 
https://bugs.webkit.org/show_bug.cgi?id=203226
Summary Add a script to run ImageDiff manually
Carlos Alberto Lopez Perez
Reported 2019-10-21 17:05:54 PDT
While trying to debug a possible issue with ImageDiff I found that is really hard to run this test manually (without using the layout-test runner). The main issue is that the tool doesn't accept the paths to the images. Instead it expects via stdin the contents of both images (as byte strings), with some fields that tell it how much bytes each image uses on stdin.
Attachments
Patch (4.72 KB, patch)
2019-10-21 17:52 PDT, Carlos Alberto Lopez Perez 		no flags
DetailsFormatted DiffDiff
Patch (4.72 KB, patch)
2019-10-21 18:22 PDT, Carlos Alberto Lopez Perez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Carlos Alberto Lopez Perez
Comment 1 2019-10-21 17:52:38 PDT
Created attachment 381489 [details] Patch
Carlos Alberto Lopez Perez
Comment 2 2019-10-21 18:22:50 PDT
Created attachment 381494 [details] Patch
Adrian Perez
Comment 3 2019-10-22 01:02:59 PDT
Comment on attachment 381494 [details] Patch The new Python script looks fine. I think that the failed test case of the “webkitperl” EWS is somewhat intermittent (for example here's another recent failure: https://ews-build.webkit.org/#/builders/19/builds/11760), and it should be fine to land this.
Carlos Alberto Lopez Perez
Comment 4 2019-10-22 04:34:09 PDT
Comment on attachment 381494 [details] Patch Clearing flags on attachment: 381494 Committed r251428: <https://trac.webkit.org/changeset/251428>
Carlos Alberto Lopez Perez
Comment 5 2019-10-22 04:34:13 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2019-10-22 04:35:16 PDT
<rdar://problem/56496270>
Nikolas Zimmermann
Comment 7 2022-07-14 14:21:26 PDT
``` nzimmermann@nzimmermann-macbook WebKit % run-imagediff LayoutTests/svg/foreignObject/body-background-expected.png actual.png Traceback (most recent call last): File "/Users/nzimmermann/Software/GitRepositories/WebKit/Tools/Scripts/run-imagediff", line 70, in <module> image_diff, diff_percent, error = port.diff_image(imageContentA, imageContentB, options.tolerance) TypeError: cannot unpack non-iterable ImageDiffResult object ``` The script is outdated. Shall we update it? Carlos?
Note You need to log in before you can comment on or make changes to this bug.