After a call to WebResourceLoadStatisticsStore::logUserInteraction(), we should update cookie blocking state in NetworkStorageSession if this interaction changed the domain's hadUserInteraction field to true.
<rdar://problem/56464567>
Created attachment 381420 [details] Patch
Created attachment 381433 [details] Patch
Cc'ing Chris for him to take a look at the innerCompletionHandler part.
Comment on attachment 381433 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=381433&action=review LGTM with 1 nit. > Source/WebKit/NetworkProcess/Classifier/WebResourceLoadStatisticsStore.cpp:551 > + postTaskReply([completionHandler = WTFMove(completionHandler)]() mutable { Doesn't postTaskReply(WTFMove(completionHandler)); work?
(In reply to Chris Dumez from comment #5) > Comment on attachment 381433 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=381433&action=review > > LGTM with 1 nit. > > > Source/WebKit/NetworkProcess/Classifier/WebResourceLoadStatisticsStore.cpp:551 > > + postTaskReply([completionHandler = WTFMove(completionHandler)]() mutable { > > Doesn't postTaskReply(WTFMove(completionHandler)); work? I actually started that way then reviewed how we've done it previously. I'll switch to that. Thanks both of you!
Created attachment 381448 [details] Patch for landing
Comment on attachment 381448 [details] Patch for landing Clearing flags on attachment: 381448 Committed r251391: <https://trac.webkit.org/changeset/251391>
All reviewed patches have been landed. Closing bug.