Bug 203195 – Resource Load Statistics: Update cookie blocking in NetworkStorageSession after first user interaction

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[John Wilander]

After a call to WebResourceLoadStatisticsStore::logUserInteraction(), we should update cookie blocking state in NetworkStorageSession if this interaction changed the domain's hadUserInteraction field to true.

[Radar WebKit Bug Importer]

<rdar://problem/56464567>

[John Wilander]

Created attachment 381420 [details]
Patch

[John Wilander]

Created attachment 381433 [details]
Patch

[John Wilander]

Cc'ing Chris for him to take a look at the innerCompletionHandler part.

[Chris Dumez]

Comment on attachment 381433 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=381433&action=review

LGTM with 1 nit.

> Source/WebKit/NetworkProcess/Classifier/WebResourceLoadStatisticsStore.cpp:551
> +            postTaskReply([completionHandler = WTFMove(completionHandler)]() mutable {

Doesn't postTaskReply(WTFMove(completionHandler)); work?

[John Wilander]

(In reply to Chris Dumez from comment #5)
> Comment on attachment 381433 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=381433&action=review
> 
> LGTM with 1 nit.
> 
> > Source/WebKit/NetworkProcess/Classifier/WebResourceLoadStatisticsStore.cpp:551
> > +            postTaskReply([completionHandler = WTFMove(completionHandler)]() mutable {
> 
> Doesn't postTaskReply(WTFMove(completionHandler)); work?

I actually started that way then reviewed how we've done it previously. I'll switch to that.

Thanks both of you!

[John Wilander]

Created attachment 381448 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 381448 [details]
Patch for landing

Clearing flags on attachment: 381448

Committed r251391: <https://trac.webkit.org/changeset/251391>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.