[GStreamer] Several issues while trying to play a video on NextCloud

[Sergio Villar Senin]

I'm experiencing several issues when trying to play a video hosted on a nextcloud installation:

* the playback is choppy, it starts, then I got several cuts and finally it becomes stalled
* the download bar grows a bit and then stops
* the progress indicator behaviour is weird, as it moves faster than the download bar

Note that the video plays fine if I download it.

PS: the aforementioned video is hosted in a private installation, I can give further details privately.

[Philippe Normand]

Most likely an issue in the GStreamer webkithttpsrc element.

[Xabier Rodríguez Calvar]

Created attachment 383346 [details]
Patch

[Philippe Normand]

Comment on attachment 383346 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=383346&action=review

> Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:468
> -                && (GST_STATE(src) == GST_STATE_PLAYING) && priv->isDownloadSuspended) {
> +                && (GST_STATE(src) == GST_STATE_PLAYING || GST_STATE(src) == GST_STATE_PAUSED) && priv->isDownloadSuspended) {

Could be simplified to GST_STATE(src) >= GST_STATE_PAUSED

> Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.h:38
> +#define WEBKIT_WEB_SRC_CAST(obj)           ((WebKitWebSrc*)(obj))

Odd indentation here :)

[Xabier Rodríguez Calvar]

Created attachment 383351 [details]
Patch for landing

[Xabier Rodríguez Calvar]

Created attachment 383352 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 383352 [details]
Patch for landing

Clearing flags on attachment: 383352

Committed r252398: <https://trac.webkit.org/changeset/252398>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Xabier Rodríguez Calvar]

I could reproduce this bug again.

[Philippe Normand]

*** Bug 204410 has been marked as a duplicate of this bug. ***

[Philippe Normand]

With current ToT here playback doesn't even start... The pipeline seems stuck in an ASYNC state change.

[Xabier Rodríguez Calvar]

Have you tried patch for bug 205275 ?

[Philippe Normand]

(In reply to Xabier Rodríguez Calvar from comment #11)
> Have you tried patch for bug 205275 ?

Yes and the video plays now. I was just saying the original issue reported is now different from what I observe without patches.

[Xabier Rodríguez Calvar]

(In reply to Philippe Normand from comment #12)
> Yes and the video plays now. I was just saying the original issue reported
> is now different from what I observe without patches.

I observed several of this things while working on this bug that I tried to fix but as the patch was getting big, I thought I could push what I had and tackle the "low bandwidth pause" back here.

[Alicia Boya García]

The video is working fine after the WebKitWebSrc threading rework.

*** This bug has been marked as a duplicate of bug 210284 ***