Bug 203191 - [GTK] C++ comments used in C header files
Summary: [GTK] C++ comments used in C header files
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2019-10-21 03:20 PDT by Milan Crha
Modified: 2019-10-22 01:48 PDT (History)
6 users (show)

See Also:

Patch (6.96 KB, patch)
2019-10-21 04:42 PDT, Carlos Garcia Campos
zan: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Milan Crha 2019-10-21 03:20:07 PDT
I just tried to compile Evolution with -ansi -D_DEFAULT_SOURCE=1 and I see a lot of warnings coming from WebKitGTK+ like this:

/usr/include/webkitgtk-4.0/webkit2/WebKitAutocleanups.h:88:8: warning: extra tokens at end of #endif directive [-Wendif-labels]
   88 | #endif // WebKitAutocleanups_h

There are a lot of these, from various files.

The fix is to use C comments, thus:

 #endif /* WebKitAutocleanups_h */
Comment 1 Carlos Garcia Campos 2019-10-21 04:42:24 PDT
Created attachment 381412 [details]
Comment 2 EWS Watchlist 2019-10-21 04:43:12 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 3 Carlos Garcia Campos 2019-10-22 01:48:31 PDT
Committed r251423: <https://trac.webkit.org/changeset/251423>