Bug 203188 - Remove all uses of untagCodePtr in debugging code.
Summary: Remove all uses of untagCodePtr in debugging code.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-10-20 23:45 PDT by Mark Lam
Modified: 2019-10-21 12:17 PDT (History)
11 users (show)

See Also:

Attachments
proposed patch. (5.34 KB, patch)
2019-10-20 23:56 PDT, Mark Lam 		no flags Details | Formatted Diff | Diff
proposed patch. (5.48 KB, patch)
2019-10-20 23:59 PDT, Mark Lam 		ysuzuki: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2019-10-20 23:45:19 PDT 
We want the ability to always assert on failure to authenticate in untagCodePtr.
Comment 1 Radar WebKit Bug Importer 2019-10-20 23:45:46 PDT 
<rdar://problem/56453043>
Comment 2 Mark Lam 2019-10-20 23:56:17 PDT 
Created attachment 381404 [details]
proposed patch.
Comment 3 Mark Lam 2019-10-20 23:59:15 PDT 
Created attachment 381405 [details]
proposed patch.
Comment 4 Yusuke Suzuki 2019-10-21 12:09:31 PDT 
Comment on attachment 381405 [details]
proposed patch.

r=me
Comment 5 Mark Lam 2019-10-21 12:17:09 PDT 
Thanks for the review.  Landed in r251372: <http://trac.webkit.org/r251372>.