Bug 203185 - Closing a MiniBrowser WK2 window does not release the WKWebView
Summary: Closing a MiniBrowser WK2 window does not release the WKWebView
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-10-19 20:45 PDT by Simon Fraser (smfr)
Modified: 2020-02-01 23:08 PST (History)
6 users (show)

See Also:


Attachments
Patch (1.59 KB, patch)
2020-02-01 12:51 PST, Simon Fraser (smfr)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2019-10-19 20:45:13 PDT
I noticed that video keeps playing after closing its containing MiniBrowser window. We never hit -[WKWebView dealloc]. Need to figure out who's keeping it alive.
Comment 1 Simon Fraser (smfr) 2020-02-01 12:43:10 PST
This is creating a retain cycle:

    _textFinder.hideInterfaceCallback = ^{
        [_webView _hideFindUI];
    };
Comment 2 Simon Fraser (smfr) 2020-02-01 12:51:56 PST
Created attachment 389465 [details]
Patch
Comment 3 WebKit Commit Bot 2020-02-01 14:26:39 PST
Comment on attachment 389465 [details]
Patch

Clearing flags on attachment: 389465

Committed r255543: <https://trac.webkit.org/changeset/255543>
Comment 4 WebKit Commit Bot 2020-02-01 14:26:40 PST
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2020-02-01 14:27:17 PST
<rdar://problem/59090239>
Comment 6 Tim Horton 2020-02-01 23:08:29 PST
There's a warning for that that we should consider turning on!