Bug 203183 - [LFC][IFC] Move the collapsed bit from InlineItems to runs
Summary: [LFC][IFC] Move the collapsed bit from InlineItems to runs
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-10-19 13:07 PDT by zalan
Modified: 2019-10-20 08:00 PDT (History)
5 users (show)

See Also:

Attachments
Patch (14.73 KB, patch)
2019-10-19 13:30 PDT, zalan 		koivisto: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2019-10-19 13:07:51 PDT 
This way when collapsing style change, we don't have to re-traverse the IFC tree to collect the InlineItems.
Comment 1 Radar WebKit Bug Importer 2019-10-19 13:08:55 PDT 
<rdar://problem/56437181>
Comment 2 zalan 2019-10-19 13:30:34 PDT 
Created attachment 381375 [details]
Patch
Comment 3 Antti Koivisto 2019-10-20 00:34:33 PDT 
Comment on attachment 381375 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=381375&action=review

> Source/WebCore/ChangeLog:3
> +        [LFC][IFC] Move the collapsed bit from InlineItems to runs

LayoutTests/imported/w3c/web-platform-tests/css/css-text/white-space has good test coverage for this stuff. Would be good to get them running.

> Source/WebCore/ChangeLog:12
> +        This patch also fixes leading/training content preservation. 

typo 'trailing'
Comment 4 zalan 2019-10-20 07:56:38 PDT 
Committed r251329: <https://trac.webkit.org/changeset/251329>
Comment 5 zalan 2019-10-20 08:00:40 PDT 
(In reply to Antti Koivisto from comment #3)
> Comment on attachment 381375 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=381375&action=review
> 
> > Source/WebCore/ChangeLog:3
> > +        [LFC][IFC] Move the collapsed bit from InlineItems to runs
> 
> LayoutTests/imported/w3c/web-platform-tests/css/css-text/white-space has
> good test coverage for this stuff. Would be good to get them running.
> 
I am going to land a few more changes and test-run WPT to see what passes.