RESOLVED FIXED 203183
[LFC][IFC] Move the collapsed bit from InlineItems to runs 
https://bugs.webkit.org/show_bug.cgi?id=203183
Summary [LFC][IFC] Move the collapsed bit from InlineItems to runs
zalan
Reported 2019-10-19 13:07:51 PDT
This way when collapsing style change, we don't have to re-traverse the IFC tree to collect the InlineItems.
Attachments
Patch (14.73 KB, patch)
2019-10-19 13:30 PDT, zalan 		koivisto: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2019-10-19 13:08:55 PDT
<rdar://problem/56437181>
zalan
Comment 2 2019-10-19 13:30:34 PDT
Created attachment 381375 [details] Patch
Antti Koivisto
Comment 3 2019-10-20 00:34:33 PDT
Comment on attachment 381375 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=381375&action=review > Source/WebCore/ChangeLog:3 > + [LFC][IFC] Move the collapsed bit from InlineItems to runs LayoutTests/imported/w3c/web-platform-tests/css/css-text/white-space has good test coverage for this stuff. Would be good to get them running. > Source/WebCore/ChangeLog:12 > + This patch also fixes leading/training content preservation. typo 'trailing'
zalan
Comment 4 2019-10-20 07:56:38 PDT
Committed r251329: <https://trac.webkit.org/changeset/251329>
zalan
Comment 5 2019-10-20 08:00:40 PDT
(In reply to Antti Koivisto from comment #3) > Comment on attachment 381375 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=381375&action=review > > > Source/WebCore/ChangeLog:3 > > + [LFC][IFC] Move the collapsed bit from InlineItems to runs > > LayoutTests/imported/w3c/web-platform-tests/css/css-text/white-space has > good test coverage for this stuff. Would be good to get them running. > I am going to land a few more changes and test-run WPT to see what passes.
Note You need to log in before you can comment on or make changes to this bug.