Remove font-variant @font-face descriptor
Created attachment 381363 [details] WIP
Created attachment 381645 [details] Patch
Created attachment 381710 [details] Patch
Created attachment 381862 [details] Patch
It sounds like all the indications we have, both internally to Apple and externally, is that this is safe to remove.
Comment on attachment 381862 [details] Patch Rejecting attachment 381862 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 381862, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Logging in as commit-queue@webkit.org... Fetching: https://bugs.webkit.org/attachment.cgi?id=381862&action=edit Fetching: https://bugs.webkit.org/show_bug.cgi?id=203179&ctype=xml&excludefield=attachmentdata Processing 1 patch from 1 bug. Processing patch 381862 from bug 203179. Fetching: https://bugs.webkit.org/attachment.cgi?id=381862 Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Simon Fraser']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Parsed 40 diffs from patch file(s). patching file Source/WebCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebCore/css/CSSFontFace.cpp patching file Source/WebCore/css/CSSFontFace.h patching file Source/WebCore/css/CSSFontFaceSource.cpp patching file Source/WebCore/css/CSSFontFaceSource.h patching file Source/WebCore/css/CSSFontSelector.cpp patching file Source/WebCore/css/FontFace.cpp patching file Source/WebCore/css/FontFace.h patching file Source/WebCore/css/FontFace.idl patching file Source/WebCore/loader/cache/CachedFont.cpp patching file Source/WebCore/loader/cache/CachedFont.h patching file Source/WebCore/loader/cache/CachedSVGFont.cpp patching file Source/WebCore/loader/cache/CachedSVGFont.h patching file Source/WebCore/platform/graphics/FontCache.cpp patching file Source/WebCore/platform/graphics/FontCache.h Hunk #3 succeeded at 289 with fuzz 1. patching file Source/WebCore/platform/graphics/cairo/FontCustomPlatformData.h patching file Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp Hunk #4 succeeded at 1292 (offset 1 line). Hunk #5 succeeded at 1304 (offset 1 line). Hunk #6 succeeded at 1339 (offset 1 line). Hunk #7 succeeded at 1354 (offset 1 line). Hunk #8 succeeded at 1483 (offset 1 line). patching file Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.h patching file Source/WebCore/platform/graphics/cocoa/FontFamilySpecificationCoreText.cpp patching file Source/WebCore/platform/graphics/freetype/FontCacheFreeType.cpp Hunk #1 succeeded at 500 (offset 124 lines). patching file Source/WebCore/platform/graphics/freetype/FontCustomPlatformDataFreeType.cpp patching file Source/WebCore/platform/graphics/mac/FontCustomPlatformData.cpp patching file Source/WebCore/platform/graphics/mac/FontCustomPlatformData.h patching file Source/WebCore/platform/graphics/win/FontCacheWin.cpp patching file Source/WebCore/platform/graphics/win/FontCustomPlatformData.cpp patching file Source/WebCore/platform/graphics/win/FontCustomPlatformData.h patching file Source/WebCore/platform/graphics/win/FontCustomPlatformDataCairo.cpp patching file LayoutTests/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file LayoutTests/css3/font-variant-font-face-all-expected.html rm 'LayoutTests/css3/font-variant-font-face-all-expected.html' patching file LayoutTests/css3/font-variant-font-face-all.html rm 'LayoutTests/css3/font-variant-font-face-all.html' patching file LayoutTests/css3/font-variant-font-face-override-expected.html patching file LayoutTests/css3/font-variant-font-face-override.html patching file LayoutTests/fast/text/font-face-empty-string-expected.txt patching file LayoutTests/fast/text/font-face-empty-string.html patching file LayoutTests/fast/text/font-face-javascript-expected.txt Hunk #2 FAILED at 18. 1 out of 2 hunks FAILED -- saving rejects to file LayoutTests/fast/text/font-face-javascript-expected.txt.rej patching file LayoutTests/fast/text/font-face-javascript.html Hunk #2 FAILED at 26. 1 out of 3 hunks FAILED -- saving rejects to file LayoutTests/fast/text/font-face-javascript.html.rej patching file LayoutTests/platform/gtk/TestExpectations Hunk #1 succeeded at 846 (offset -10 lines). patching file LayoutTests/platform/win/TestExpectations Hunk #1 succeeded at 529 (offset -6 lines). patching file LayoutTests/platform/wincairo/TestExpectations Hunk #1 succeeded at 1172 (offset -10 lines). patching file LayoutTests/platform/wpe/TestExpectations Hunk #1 succeeded at 1585 (offset 53 lines). Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Simon Fraser']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: https://webkit-queues.webkit.org/results/13269971
Created attachment 384118 [details] Patch for committing
Comment on attachment 384118 [details] Patch for committing Clearing flags on attachment: 384118 Committed r252760: <https://trac.webkit.org/changeset/252760>
<rdar://problem/57445336>