Bug 203175 - macCatalyst: Cursor should send mouse events, not touch events
Summary: macCatalyst: Cursor should send mouse events, not touch events
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-10-18 17:28 PDT by Tim Horton
Modified: 2019-10-18 22:48 PDT (History)
13 users (show)

See Also:

Attachments
Patch (37.33 KB, patch)
2019-10-18 17:29 PDT, Tim Horton 		no flags Details | Formatted Diff | Diff
Patch (37.37 KB, patch)
2019-10-18 17:53 PDT, Tim Horton 		no flags Details | Formatted Diff | Diff
Patch (37.39 KB, patch)
2019-10-18 18:22 PDT, Tim Horton 		no flags Details | Formatted Diff | Diff
Patch (37.38 KB, patch)
2019-10-18 18:23 PDT, Tim Horton 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2019-10-18 17:28:36 PDT 
macCatalyst: Cursor should send mouse events, not touch events
Comment 1 Tim Horton 2019-10-18 17:29:14 PDT 
Created attachment 381353 [details]
Patch
Comment 2 Tim Horton 2019-10-18 17:29:18 PDT 
<rdar://problem/56321134>
Comment 3 Tim Horton 2019-10-18 17:53:22 PDT 
Created attachment 381358 [details]
Patch
Comment 4 Simon Fraser (smfr) 2019-10-18 18:03:35 PDT 
Comment on attachment 381358 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=381358&action=review

> Source/WebKit/UIProcess/ios/WKMouseGestureRecognizer.mm:57
> +    Optional<WebKit::NativeWebMouseEvent> _lastEvent;

std::unique_ptr<>?

> Source/WebKit/UIProcess/ios/WKMouseGestureRecognizer.mm:146
> +    auto timestamp = WallTime::fromRawSeconds(GSCurrentEventTimestamp() / 1000000000.0);

Don't we have a nanosecondsToMumble?
Comment 5 Tim Horton 2019-10-18 18:22:35 PDT 
Created attachment 381359 [details]
Patch
Comment 6 Tim Horton 2019-10-18 18:23:56 PDT 
Created attachment 381360 [details]
Patch
Comment 7 WebKit Commit Bot 2019-10-18 22:48:21 PDT 
Comment on attachment 381360 [details]
Patch

Clearing flags on attachment: 381360

Committed r251320: <https://trac.webkit.org/changeset/251320>
Comment 8 WebKit Commit Bot 2019-10-18 22:48:23 PDT 
All reviewed patches have been landed.  Closing bug.