Bug 203173 – [ Mac WK1 ] REGRESSION (r251261): Layout Test inspector/console/webcore-logging.html is consistently Failing

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Russell Epstein]

The following layout test is failing consistently on Mac after the changes landed in r251261:

inspector/console/webcore-logging.html

Steps to Reproduce:

run-webkit-tests --no-retry --no-sample-on-timeout inspector/console/webcore-logging.html -1 --iter 20

Test History:

https://results.webkit.org/?suite=layout-tests&test=inspector%2Fconsole%2Fwebcore-logging.html

Diff:

--- /Volumes/Data/slave/mojave-release-tests-wk1/build/layout-test-results/inspector/console/webcore-logging-expected.txt
+++ /Volumes/Data/slave/mojave-release-tests-wk1/build/layout-test-results/inspector/console/webcore-logging-actual.txt
@@ -27,11 +27,14 @@
 -- Running test case: Console.Logging.MediaLogging
 PASS: Media logging disabled.
 PASS: Media logging has been enabled.
-PASS: Media log message should have source 'media'.
+FAIL: Media log message should have source 'media'.
+    Expected: truthy
+    Actual: false
 
 -- Running test case: Console.Logging.LogAsJSONWithoutRepeat
 PASS: Media logging disabled.
 PASS: Verbose media logging has been enabled.
+ASSERT: undefined
 PASS: Message logged as JSON.
 PASS: ConsoleMessage repeatCount is 1.
 PASS: Message logged as JSON.

[Radar WebKit Bug Importer]

<rdar://problem/56424721>

[Russell Epstein]

Updated TestExpectations in r251313

[Sihui Liu]

Created attachment 381422 [details]
Patch

[Sihui Liu]

*** Bug 203118 has been marked as a duplicate of this bug. ***

[EWS Watchlist]

Comment on attachment 381422 [details]
Patch

Attachment 381422 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/13159659

New failing tests:
fast/repaint/backgroundSizeRepaint.html

[EWS Watchlist]

Created attachment 381429 [details]
Archive of layout-test-results from ews213 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews213  Port: win-future  Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit

[EWS Watchlist]

Comment on attachment 381422 [details]
Patch

Attachment 381422 [details] did not pass jsc-ews (mac):
Output: https://webkit-queues.webkit.org/results/13159780

New failing tests:
mozilla-tests.yaml/js1_5/Array/regress-101964.js.mozilla-dfg-eager-no-cjit-validate-phases

[Geoffrey Garen]

Comment on attachment 381422 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=381422&action=review

r=me

> LayoutTests/ChangeLog:9
> +        play() returns a promise and the promise can be rejected by a later ause(). We didn't handle

pause()

[Sihui Liu]

Created attachment 381692 [details]
Patch for landing

[Sihui Liu]

Created attachment 381694 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 381694 [details]
Patch for landing

Clearing flags on attachment: 381694

Committed r251482: <https://trac.webkit.org/changeset/251482>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Truitt Savell]

Reverted r251482 for reason:

r251261 broke multiple tests, reverting this as part of that rollout.

Committed r251513: <https://trac.webkit.org/changeset/251513>

[Alexey Proskuryakov]

Marking as fixed again. The test fix got rolled back, but the issue doesnt' exist on trunk at this point.

[Geoffrey Garen]

I think we want to re-land r251482; it was an error to roll it out, since it fixed a bug and did not cause any test failures.

[Sihui Liu]

Created attachment 381844 [details]
Patch for landing

[Sihui Liu]

(In reply to Sihui Liu from comment #16)
> Created attachment 381844 [details]
> Patch for landing

Relanding this patch per https://bugs.webkit.org/show_bug.cgi?id=203173#c15.

[WebKit Commit Bot]

Comment on attachment 381844 [details]
Patch for landing

Clearing flags on attachment: 381844

Committed r251565: <https://trac.webkit.org/changeset/251565>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.