Bug 203170 – Add MediaCapabilities support for DolbyVision codecs.

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Jer Noble]

Add MediaCapabilities support for DolbyVision codecs.

[Jer Noble]

Created attachment 381343 [details]
Patch

[Jer Noble]

<rdar://problem/35131321>

[Eric Carlson]

Comment on attachment 381343 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=381343&action=review

> Source/WebCore/platform/graphics/HEVCUtilities.cpp:178
> +    switch (profileID) {
> +    case 9:  return codecName == "avc1" || codecName == "avc3";
> +    default: return codecName == "hvc1" || codecName == "hev1";

Nit: a switch statement with one case and a default is odd, why not just use:

    if (profileID == 9) 
        return codecName == "avc1" || codecName == "avc3";

    return codecName == "hvc1" || codecName == "hev1";

> Source/WebCore/platform/graphics/HEVCUtilities.cpp:189
> +    if (nextElement == codecSplit.end())
> +        return WTF::nullopt;

if (nextElement == codecSplit.end() || ++nextElement == codecSplit.end())
    return WTF::nullopt;

> Source/WebCore/platform/graphics/cocoa/HEVCUtilitiesCocoa.mm:196
> +    auto& map = codecStringToCodecTypeMap();
> +    auto findResult = map.find(parameters.codecName);
> +    if (findResult == map.end())
> +        return false;
> +    auto codecType = findResult->value;

Nit: Any reason to not wrap this in a function like you did with profileIDForAlphabeticDoViProfile and codecStringForDoViCodecType?

[Jer Noble]

Comment on attachment 381343 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=381343&action=review

>> Source/WebCore/platform/graphics/HEVCUtilities.cpp:178
>> +    default: return codecName == "hvc1" || codecName == "hev1";
> 
> Nit: a switch statement with one case and a default is odd, why not just use:
> 
>     if (profileID == 9) 
>         return codecName == "avc1" || codecName == "avc3";
> 
>     return codecName == "hvc1" || codecName == "hev1";

Sure.

>> Source/WebCore/platform/graphics/HEVCUtilities.cpp:189
>> +        return WTF::nullopt;
> 
> if (nextElement == codecSplit.end() || ++nextElement == codecSplit.end())
>     return WTF::nullopt;

No this would skip the codec type portion of the string. Need that later.

>> Source/WebCore/platform/graphics/cocoa/HEVCUtilitiesCocoa.mm:196
>> +    auto codecType = findResult->value;
> 
> Nit: Any reason to not wrap this in a function like you did with profileIDForAlphabeticDoViProfile and codecStringForDoViCodecType?

I only split it out before because I ended up with multiple “auto& map =...” statements. But yes, I should convert this into a static query instead.

[Jer Noble]

Created attachment 381352 [details]
Patch for landing

[Jer Noble]

Created attachment 381435 [details]
Patch for landing

[Jer Noble]

Created attachment 381441 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 381441 [details]
Patch for landing

Clearing flags on attachment: 381441

Committed r251396: <https://trac.webkit.org/changeset/251396>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.