Bug 203155 – Web Inspector: Elements: $0 is shown for the wrong node when selecting elements in a user agent shadow tree

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Devin Rousso]

# STEPS TO REPRODUCE:
1. inspect any page with a UserAgent shadow tree (e.g. an `<input>`)
2. in the Elements Tab, select a node inside the UserAgent shadow tree
 => $0 appears next to the newly selected node
3. evaluate `$0` in the Console
 => the previously selected node (NOT the node inside the UserAgent shadow tree) is logged

[Devin Rousso]

Created attachment 381311 [details]
Patch

[Matt Baker]

Comment on attachment 381311 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=381311&action=review

r=me

> Source/WebInspectorUI/ChangeLog:8
> +        Rather than "blindly" using the last selected node (from `WI.TreeOutline`), we should wait

Switch to a more descriptive term like 'naively', so you can eliminate the double-quotes.

> Source/WebInspectorUI/ChangeLog:9
> +        to see if the inspected page actually "accepts" the selected node as being inspectable and

Let's not use quotation marks around words like this. AMA style says that other than quoting material directly from a source, quotation marks are used "to introduce a word or phrase used as an ironic comment, as slang, or as an invented or coined expression". Pick words that are more technical/descriptive if necessary, or just remove the quotes.

[Devin Rousso]

Created attachment 381326 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 381326 [details]
Patch

Clearing flags on attachment: 381326

Committed r251302: <https://trac.webkit.org/changeset/251302>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/56421773>