Bug 203147 - [WebAuthn] Warn users when no credentials are found
Summary: [WebAuthn] Warn users when no credentials are found
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jiewen Tan
URL:
Keywords: InRadar
Depends on:
Blocks: 181943
  Show dependency treegraph
 
Reported: 2019-10-18 02:25 PDT by Jiewen Tan
Modified: 2019-10-22 03:10 PDT (History)
4 users (show)

See Also:


Attachments
Patch (43.45 KB, patch)
2019-10-18 14:25 PDT, Jiewen Tan
no flags Details | Formatted Diff | Diff
Patch (48.80 KB, patch)
2019-10-18 14:48 PDT, Jiewen Tan
bfulgham: review+
Details | Formatted Diff | Diff
Patch for landing (48.77 KB, patch)
2019-10-18 16:37 PDT, Jiewen Tan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jiewen Tan 2019-10-18 02:25:57 PDT
Warn users when no credentials are found.
Comment 1 Jiewen Tan 2019-10-18 02:26:12 PDT
<rdar://problem/55931123>
Comment 2 Jiewen Tan 2019-10-18 14:25:05 PDT
Created attachment 381328 [details]
Patch
Comment 3 Jiewen Tan 2019-10-18 14:48:49 PDT
Created attachment 381334 [details]
Patch
Comment 4 Brent Fulgham 2019-10-18 16:25:21 PDT
Comment on attachment 381334 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=381334&action=review

r=me

> Source/WebKit/UIProcess/WebAuthentication/AuthenticatorManager.cpp:248
> +    if (auto *panel = m_pendingRequestData.panel.get())

auto* panel
This isn't an Objective C file... but is this an ObjC data type?

> Tools/TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm:58
> +        return;

This 'return' isn't really needed.

> Tools/TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm:92
> +    RetainPtr<NSObject <_WKWebAuthenticationPanelDelegate>> _delegate;

The whitespace between NSObject and < is not needed.
Comment 5 Jiewen Tan 2019-10-18 16:34:50 PDT
Comment on attachment 381334 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=381334&action=review

Thanks Brent for r+ this patch.

>> Source/WebKit/UIProcess/WebAuthentication/AuthenticatorManager.cpp:248
>> +    if (auto *panel = m_pendingRequestData.panel.get())
> 
> auto* panel
> This isn't an Objective C file... but is this an ObjC data type?

Oops. Fixed.

>> Tools/TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm:58
>> +        return;
> 
> This 'return' isn't really needed.

Right. Fixed.

>> Tools/TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm:92
>> +    RetainPtr<NSObject <_WKWebAuthenticationPanelDelegate>> _delegate;
> 
> The whitespace between NSObject and < is not needed.

Fixed.
Comment 6 Jiewen Tan 2019-10-18 16:37:37 PDT
Created attachment 381344 [details]
Patch for landing
Comment 7 WebKit Commit Bot 2019-10-18 18:02:26 PDT
Comment on attachment 381344 [details]
Patch for landing

Clearing flags on attachment: 381344

Committed r251317: <https://trac.webkit.org/changeset/251317>