Warn users when no credentials are found.
<rdar://problem/55931123>
Created attachment 381328 [details] Patch
Created attachment 381334 [details] Patch
Comment on attachment 381334 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=381334&action=review r=me > Source/WebKit/UIProcess/WebAuthentication/AuthenticatorManager.cpp:248 > + if (auto *panel = m_pendingRequestData.panel.get()) auto* panel This isn't an Objective C file... but is this an ObjC data type? > Tools/TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm:58 > + return; This 'return' isn't really needed. > Tools/TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm:92 > + RetainPtr<NSObject <_WKWebAuthenticationPanelDelegate>> _delegate; The whitespace between NSObject and < is not needed.
Comment on attachment 381334 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=381334&action=review Thanks Brent for r+ this patch. >> Source/WebKit/UIProcess/WebAuthentication/AuthenticatorManager.cpp:248 >> + if (auto *panel = m_pendingRequestData.panel.get()) > > auto* panel > This isn't an Objective C file... but is this an ObjC data type? Oops. Fixed. >> Tools/TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm:58 >> + return; > > This 'return' isn't really needed. Right. Fixed. >> Tools/TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm:92 >> + RetainPtr<NSObject <_WKWebAuthenticationPanelDelegate>> _delegate; > > The whitespace between NSObject and < is not needed. Fixed.
Created attachment 381344 [details] Patch for landing
Comment on attachment 381344 [details] Patch for landing Clearing flags on attachment: 381344 Committed r251317: <https://trac.webkit.org/changeset/251317>