RESOLVED FIXED Bug 203147
[WebAuthn] Warn users when no credentials are found 
https://bugs.webkit.org/show_bug.cgi?id=203147
Summary [WebAuthn] Warn users when no credentials are found
Jiewen Tan
Reported 2019-10-18 02:25:57 PDT
Warn users when no credentials are found.
Attachments
Patch (43.45 KB, patch)
2019-10-18 14:25 PDT, Jiewen Tan 		no flags
DetailsFormatted DiffDiff
Patch (48.80 KB, patch)
2019-10-18 14:48 PDT, Jiewen Tan 		bfulgham: review+
DetailsFormatted DiffDiff
Patch for landing (48.77 KB, patch)
2019-10-18 16:37 PDT, Jiewen Tan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jiewen Tan
Comment 1 2019-10-18 02:26:12 PDT
<rdar://problem/55931123>
Jiewen Tan
Comment 2 2019-10-18 14:25:05 PDT
Created attachment 381328 [details] Patch
Jiewen Tan
Comment 3 2019-10-18 14:48:49 PDT
Created attachment 381334 [details] Patch
Brent Fulgham
Comment 4 2019-10-18 16:25:21 PDT
Comment on attachment 381334 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=381334&action=review r=me > Source/WebKit/UIProcess/WebAuthentication/AuthenticatorManager.cpp:248 > + if (auto *panel = m_pendingRequestData.panel.get()) auto* panel This isn't an Objective C file... but is this an ObjC data type? > Tools/TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm:58 > + return; This 'return' isn't really needed. > Tools/TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm:92 > + RetainPtr<NSObject <_WKWebAuthenticationPanelDelegate>> _delegate; The whitespace between NSObject and < is not needed.
Jiewen Tan
Comment 5 2019-10-18 16:34:50 PDT
Comment on attachment 381334 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=381334&action=review Thanks Brent for r+ this patch. >> Source/WebKit/UIProcess/WebAuthentication/AuthenticatorManager.cpp:248 >> + if (auto *panel = m_pendingRequestData.panel.get()) > > auto* panel > This isn't an Objective C file... but is this an ObjC data type? Oops. Fixed. >> Tools/TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm:58 >> + return; > > This 'return' isn't really needed. Right. Fixed. >> Tools/TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm:92 >> + RetainPtr<NSObject <_WKWebAuthenticationPanelDelegate>> _delegate; > > The whitespace between NSObject and < is not needed. Fixed.
Jiewen Tan
Comment 6 2019-10-18 16:37:37 PDT
Created attachment 381344 [details] Patch for landing
WebKit Commit Bot
Comment 7 2019-10-18 18:02:26 PDT
Comment on attachment 381344 [details] Patch for landing Clearing flags on attachment: 381344 Committed r251317: <https://trac.webkit.org/changeset/251317>
Note You need to log in before you can comment on or make changes to this bug.