Move service worker registration matching for navigation loads to network process
Created attachment 381288 [details]
Created attachment 381293 [details]
Created attachment 381299 [details]
Mac-wk1 tests are not about service workers ( fast/scrolling/latching/scroll-select-bottom-test.html and fast/events/resize-subframe-in-rendering-update.html ), so I doubt this is a regression.
Perl bot is failing test262 tests which should not be affected by this patch either.
Also previous patch was passing in WK1 and webkitperl and the changes were #ifdef for WIN compilation.
Comment on attachment 381299 [details]
View in context: https://bugs.webkit.org/attachment.cgi?id=381299&action=review
> + For regular loads, we no longer match service worker registration explicitly.
> + We still need to explicitely match registrations in those two cases:
-> Make up your mind :P
> + m_importCompletedCallbacks.append(WTFMove(callback));
I think we should ASSERT(!m_importCompleted);
> +void WebSWClientConnection::documentIsControlled(DocumentIdentifier documentIdentifier, ServiceWorkerRegistrationData&& data, CompletionHandler<void(bool)>&& completionHandler)
The naming is bad IMO. It looks like a getter but is really a setter. I'd suggest something like setDocumentIsControlled() or controlDocument().
Created attachment 381469 [details]