Bug 203136 - Refactor AbstractEventLoop out of WindowEventLoop
Summary: Refactor AbstractEventLoop out of WindowEventLoop
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Scrolling (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords: InRadar
Depends on:
Blocks: 203137
  Show dependency tree / graph
 
Reported: 2019-10-17 21:48 PDT by Ryosuke Niwa
Modified: 2019-10-18 16:34 PDT (History)
10 users (show)

See Also:

Attachments
Cleanup (9.21 KB, patch)
2019-10-17 22:41 PDT, Ryosuke Niwa 		koivisto: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2019-10-17 21:48:37 PDT 
This is to prepare for the addition of WorkerEventLoop, which is needed to integrate DOMTimer with HTML5 event loop.
Comment 1 Radar WebKit Bug Importer 2019-10-17 21:50:38 PDT 
<rdar://problem/56396749>
Comment 2 Ryosuke Niwa 2019-10-17 22:41:00 PDT 
Created attachment 381274 [details]
Cleanup
Comment 3 Antti Koivisto 2019-10-18 07:15:59 PDT 
Comment on attachment 381274 [details]
Cleanup

View in context: https://bugs.webkit.org/attachment.cgi?id=381274&action=review

> Source/WebCore/dom/AbstractEventLoop.h:40
> +class AbstractEventLoop : public RefCounted<AbstractEventLoop> {
> +    WTF_MAKE_FAST_ALLOCATED;

RefCounted is WTF_MAKE_FAST_ALLOCATED by default.

> Source/WebCore/dom/WindowEventLoop.h:37
> +class WindowEventLoop final : public AbstractEventLoop {
>      WTF_MAKE_FAST_ALLOCATED;

Not needed here either.
Comment 4 Ryosuke Niwa 2019-10-18 15:49:12 PDT 
(In reply to Antti Koivisto from comment #3)
> Comment on attachment 381274 [details]
> Cleanup
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=381274&action=review
> 
> > Source/WebCore/dom/AbstractEventLoop.h:40
> > +class AbstractEventLoop : public RefCounted<AbstractEventLoop> {
> > +    WTF_MAKE_FAST_ALLOCATED;
> 
> RefCounted is WTF_MAKE_FAST_ALLOCATED by default.

Good point. Removed.

> > Source/WebCore/dom/WindowEventLoop.h:37
> > +class WindowEventLoop final : public AbstractEventLoop {
> >      WTF_MAKE_FAST_ALLOCATED;
> 
> Not needed here either.

Ditto.
Comment 5 Ryosuke Niwa 2019-10-18 16:34:38 PDT 
Committed r251308: <https://trac.webkit.org/changeset/251308>