Bug 203134 - Integrate media query evaluation into HTML5 event loop
Summary: Integrate media query evaluation into HTML5 event loop
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords: InRadar
Depends on: 203430
Blocks: 202843
  Show dependency tree / graph
 
Reported: 2019-10-17 21:16 PDT by Ryosuke Niwa
Modified: 2019-11-05 09:37 PST (History)
24 users (show)

See Also:

Attachments
WIP (2.66 KB, patch)
2019-10-17 21:18 PDT, Ryosuke Niwa 		no flags Details | Formatted Diff | Diff
Patch (14.82 KB, patch)
2019-10-17 23:24 PDT, Ryosuke Niwa 		no flags Details | Formatted Diff | Diff
Updated for trunk (17.34 KB, patch)
2019-10-31 15:10 PDT, Ryosuke Niwa 		koivisto: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2019-10-17 21:16:46 PDT 
Media queries' listeners should be called during the step to update the rendering, not after each layout update.
Comment 1 Ryosuke Niwa 2019-10-17 21:18:43 PDT 
Created attachment 381267 [details]
WIP
Comment 2 Radar WebKit Bug Importer 2019-10-17 21:18:59 PDT 
<rdar://problem/56396316>
Comment 3 Ryosuke Niwa 2019-10-17 23:24:31 PDT 
Created attachment 381278 [details]
Patch
Comment 4 chris fleizach 2019-10-19 00:06:44 PDT 
lgtm
Comment 5 Ryosuke Niwa 2019-10-19 00:35:00 PDT 
Comment on attachment 381278 [details]
Patch

Thanks all for reviewing!
Comment 6 WebKit Commit Bot 2019-10-19 01:31:07 PDT 
Comment on attachment 381278 [details]
Patch

Clearing flags on attachment: 381278

Committed r251322: <https://trac.webkit.org/changeset/251322>
Comment 7 WebKit Commit Bot 2019-10-19 01:31:09 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 8 WebKit Commit Bot 2019-10-25 12:25:32 PDT 
Re-opened since this is blocked by bug 203430
Comment 9 Ryosuke Niwa 2019-10-31 15:10:16 PDT 
Created attachment 382507 [details]
Updated for trunk
Comment 10 Ryosuke Niwa 2019-10-31 19:19:05 PDT 
Ping reviewers. There is a minor test code change & fix since the rollout revealed a bug with respect to accessibility settings update.
Comment 11 Antti Koivisto 2019-11-01 08:17:11 PDT 
Comment on attachment 382507 [details]
Updated for trunk

View in context: https://bugs.webkit.org/attachment.cgi?id=382507&action=review

> Source/WebCore/page/Page.cpp:568
> +    forEachDocument([] (Document& document) {

We probably don't have a policy about this but no space between ] and ( wins 2:1 when searching WebCore.
Comment 12 Ryosuke Niwa 2019-11-01 11:11:47 PDT 
(In reply to Antti Koivisto from comment #11)
> Comment on attachment 382507 [details]
> Updated for trunk
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=382507&action=review
> 
> > Source/WebCore/page/Page.cpp:568
> > +    forEachDocument([] (Document& document) {
> 
> We probably don't have a policy about this but no space between ] and ( wins
> 2:1 when searching WebCore.

Huh, I always add a space there. We should probably discuss it on webkit-dev.
Comment 13 Ryosuke Niwa 2019-11-01 11:16:15 PDT 
Committed r251930: <https://trac.webkit.org/changeset/251930>