Bug 203133 - [ASAN] Fix WebGPU tests after r250258
Summary: [ASAN] Fix WebGPU tests after r250258
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGPU (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-10-17 21:06 PDT by Devin Rousso
Modified: 2019-10-18 17:44 PDT (History)
13 users (show)

See Also:

Attachments
Patch (25.46 KB, patch)
2019-10-17 21:10 PDT, Devin Rousso 		joepeck: review+
Details | Formatted Diff | Diff
Patch (25.38 KB, patch)
2019-10-18 16:09 PDT, Devin Rousso 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2019-10-17 21:06:59 PDT 
```
    ASAN=YES make debug
    ASAN=YES run-webkit-tests --debug --time-out-ms=100000 --exit-after-n-failures=1 LayoutTests/webgpu/
```

Eventually, one of the tests will fail and result in a "attempting free on address which was not malloc()-ed".
Comment 1 Devin Rousso 2019-10-17 21:07:14 PDT 
<rdar://problem/56379008>
Comment 2 Devin Rousso 2019-10-17 21:10:15 PDT 
Created attachment 381266 [details]
Patch
Comment 3 Joseph Pecoraro 2019-10-18 15:43:39 PDT 
Comment on attachment 381266 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=381266&action=review

r=me

> Source/WebCore/platform/graphics/gpu/GPUObjectBase.h:43
> +

Bad newline.
Comment 4 Devin Rousso 2019-10-18 16:09:57 PDT 
Created attachment 381341 [details]
Patch
Comment 5 WebKit Commit Bot 2019-10-18 17:44:35 PDT 
Comment on attachment 381341 [details]
Patch

Clearing flags on attachment: 381341

Committed r251315: <https://trac.webkit.org/changeset/251315>
Comment 6 WebKit Commit Bot 2019-10-18 17:44:37 PDT 
All reviewed patches have been landed.  Closing bug.