Bug 203131 - [LFC][BFC] TableFormattingContext::computedIntrinsicWidthConstraints should not expect a valid containing block's width
Summary: [LFC][BFC] TableFormattingContext::computedIntrinsicWidthConstraints should n...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-10-17 19:35 PDT by zalan
Modified: 2019-10-18 09:10 PDT (History)
5 users (show)

See Also:


Attachments
Patch (14.29 KB, patch)
2019-10-17 19:46 PDT, zalan
koivisto: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2019-10-17 19:35:12 PDT
when it is called by the preferred width computation path.
Comment 1 Radar WebKit Bug Importer 2019-10-17 19:35:31 PDT
<rdar://problem/56394676>
Comment 2 zalan 2019-10-17 19:46:56 PDT
Created attachment 381263 [details]
Patch
Comment 3 Antti Koivisto 2019-10-18 09:07:17 PDT
Comment on attachment 381263 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=381263&action=review

> Source/WebCore/layout/tableformatting/TableFormattingContext.cpp:66
> +    // 1. Position each column.

Are these references to a spec algorithm? Maybe a link?
Comment 4 zalan 2019-10-18 09:09:47 PDT
Committed r251281: <https://trac.webkit.org/changeset/251281>
Comment 5 zalan 2019-10-18 09:10:07 PDT
(In reply to Antti Koivisto from comment #3)
> Comment on attachment 381263 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=381263&action=review
> 
> > Source/WebCore/layout/tableformatting/TableFormattingContext.cpp:66
> > +    // 1. Position each column.
> 
> Are these references to a spec algorithm? Maybe a link?
good point. I'll add them.