RESOLVED FIXED 203129
[Cocoa] Move ui-serif, ui-monospaced, and ui-rounded out from behind SPI 
https://bugs.webkit.org/show_bug.cgi?id=203129
Summary [Cocoa] Move ui-serif, ui-monospaced, and ui-rounded out from behind SPI
Myles C. Maxfield
Reported 2019-10-17 18:13:15 PDT
[Cocoa] Move ui-serif, ui-monospaced, and ui-rounded out from behind SPI
Attachments
Patch (48.19 KB, patch)
2019-10-17 18:15 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Myles C. Maxfield
Comment 1 2019-10-17 18:15:23 PDT
Created attachment 381256 [details] Patch
WebKit Commit Bot
Comment 2 2019-10-21 21:05:26 PDT
Comment on attachment 381256 [details] Patch Clearing flags on attachment: 381256 Committed r251413: <https://trac.webkit.org/changeset/251413>
WebKit Commit Bot
Comment 3 2019-10-21 21:05:28 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 4 2019-10-21 21:06:18 PDT
<rdar://problem/56487980>
mitz
Comment 5 2019-10-28 20:54:13 PDT
(In reply to WebKit Commit Bot from comment #2) > Comment on attachment 381256 [details] > Patch > > Clearing flags on attachment: 381256 > > Committed r251413: <https://trac.webkit.org/changeset/251413> This broke WebKit nightly builds. As of r251673, Safari crashes on launch with 2019-10-28 20:50:07.591 SafariForWebKitDevelopment[67089:31260958] -[WKPreferences _setShouldAllowDesignSystemUIFonts:]: unrecognized selector sent to instance 0x7fb3b7649220 2019-10-28 20:50:07.640 SafariForWebKitDevelopment[67089:31260958] *** Terminating app due to uncaught exception 'NSInvalidArgumentException', reason: '-[WKPreferences _setShouldAllowDesignSystemUIFonts:]: unrecognized selector sent to instance 0x7fb3b7649220' *** First throw call stack: ( 0 CoreFoundation 0x00007fff4dc76e0b __exceptionPreprocess + 171 1 libobjc.A.dylib 0x00007fff753b0c76 objc_exception_throw + 48 2 CoreFoundation 0x00007fff4dd0f964 -[NSObject(NSObject) doesNotRecognizeSelector:] + 132 3 CoreFoundation 0x00007fff4dbec6f0 ___forwarding___ + 1456 4 CoreFoundation 0x00007fff4dbec0b8 _CF_forwarding_prep_0 + 120 5 Safari 0x000000010c10ea15 -[WebKitPreferencesManager _initializeReaderPageGroupPreferencesManager] + 69 6 Safari 0x000000010c10c424 -[WebKitPreferencesManager _initWithPreferencesType:] + 291 7 Safari 0x000000010c10bb0a __61+[WebKitPreferencesManager readerPageGroupPreferencesManager]_block_invoke + 46 8 libdispatch.dylib 0x00007fff75f90db8 _dispatch_client_callout + 8 9 libdispatch.dylib 0x00007fff75f90d6b dispatch_once_f + 41 10 Safari 0x000000010c10bad9 +[WebKitPreferencesManager readerPageGroupPreferencesManager] + 45 11 Safari 0x000000010c26cae4 ___ZN6Safari16ReaderController15readerPageGroupEv_block_invoke + 48 12 Safari 0x000000010c26ca95 _ZN6Safari16ReaderController15readerPageGroupEv + 35 13 Safari 0x000000010bec332d -[AppController _initializeProcessContext] + 1135 14 Safari 0x000000010bec2304 -[AppController init] + 847 15 AppKit 0x00007fff4b15afad -[NSCustomObject nibInstantiate] + 364 16 AppKit 0x00007fff4b15ade0 -[NSIBObjectData instantiateObject:] + 288 17 AppKit 0x00007fff4b15a391 -[NSIBObjectData nibInstantiateWithOwner:options:topLevelObjects:] + 582 18 AppKit 0x00007fff4b151959 loadNib + 435 19 AppKit 0x00007fff4b150e7d +[NSBundle(NSNibLoading) _loadNibFile:nameTable:options:withZone:ownerBundle:] + 696 20 AppKit 0x00007fff4b150ac2 -[NSBundle(NSNibLoading) loadNibNamed:owner:topLevelObjects:] + 204 21 AppKit 0x00007fff4b150883 +[NSBundle(NSNibLoading) loadNibNamed:owner:] + 447 22 AppKit 0x00007fff4b14e90e NSApplicationMain + 504 23 libdyld.dylib 0x00007fff75fca015 start + 1 24 ??? 0x0000000000000001 0x0 + 1
mitz
Comment 6 2019-10-28 20:57:25 PDT
Filed bug 203549.
Note You need to log in before you can comment on or make changes to this bug.