Bug 203128 - Remove IDBBackingStoreTemporaryFileHandler
Summary: Remove IDBBackingStoreTemporaryFileHandler
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sihui Liu
Keywords: InRadar
Depends on:
Reported: 2019-10-17 17:08 PDT by Sihui Liu
Modified: 2019-10-21 17:54 PDT (History)
7 users (show)

See Also:

Patch (18.68 KB, patch)
2019-10-17 17:16 PDT, Sihui Liu
no flags Details | Formatted Diff | Diff
Patch for landing (18.69 KB, patch)
2019-10-21 15:51 PDT, Sihui Liu
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sihui Liu 2019-10-17 17:08:53 PDT
IDBBackingStoreTemporaryFileHandler has only one member function, and implementation of that is to delete files.
We can remove this class and delete the temporary files at the places where objects of this class are used.

By doing this, we no longer need to pass the NetworkProcess/InProcessIDBServer all the way down to SQLiteIDBBackingStore, which leads to cross-thread copying.
Comment 1 Sihui Liu 2019-10-17 17:16:41 PDT
Created attachment 381253 [details]
Comment 2 Sihui Liu 2019-10-21 15:51:38 PDT
Created attachment 381470 [details]
Patch for landing
Comment 3 WebKit Commit Bot 2019-10-21 17:53:28 PDT
Comment on attachment 381470 [details]
Patch for landing

Clearing flags on attachment: 381470

Committed r251404: <https://trac.webkit.org/changeset/251404>
Comment 4 WebKit Commit Bot 2019-10-21 17:53:29 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2019-10-21 17:54:15 PDT