Bug 203125 - Only include "deep color" in layer tree dumps if a tests requests it
Summary: Only include "deep color" in layer tree dumps if a tests requests it
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-10-17 15:54 PDT by Simon Fraser (smfr)
Modified: 2019-10-17 21:25 PDT (History)
11 users (show)

See Also:

Attachments
Patch (20.25 KB, patch)
2019-10-17 15:55 PDT, Simon Fraser (smfr) 		thorton: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2019-10-17 15:54:02 PDT 
Only include "deep color" in layer tree dumps if a tests requests it
Comment 1 Simon Fraser (smfr) 2019-10-17 15:55:34 PDT 
Created attachment 381243 [details]
Patch
Comment 2 Tim Horton 2019-10-17 16:00:57 PDT 
Comment on attachment 381243 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=381243&action=review

> Source/WebCore/testing/Internals.h:374
> +        LAYER_TREE_INCLUDES_DEEP_COLOR = 1024,

Why is this not bit shifts!

> Source/WebCore/testing/Internals.idl:401
> +    const unsigned short LAYER_TREE_INCLUDES_DEEP_COLOR = 1024;

Maybe this is why
Comment 3 Simon Fraser (smfr) 2019-10-17 21:24:42 PDT 
https://trac.webkit.org/changeset/251273/webkit
Comment 4 Radar WebKit Bug Importer 2019-10-17 21:25:39 PDT 
<rdar://problem/56396406>