Bug 203117 - [ews] status bubbles should show details from all the builds in case build is retried
Summary: [ews] status bubbles should show details from all the builds in case build is...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-10-17 12:04 PDT by Aakash Jain
Modified: 2019-10-18 06:37 PDT (History)
5 users (show)

See Also:


Attachments
Patch (6.61 KB, patch)
2019-10-17 12:34 PDT, Aakash Jain
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2019-10-17 12:04:04 PDT
EWS status bubbles should show details from all the builds in case build is retried.
Comment 1 Aakash Jain 2019-10-17 12:34:50 PDT
Created attachment 381215 [details]
Patch
Comment 2 Aakash Jain 2019-10-17 12:36:23 PDT
Sample run: https://ews.webkit-uat.org/status-bubble/380828/
Notice that services bubble is listing all the retried builds.
Comment 3 Jonathan Bedard 2019-10-17 12:51:49 PDT
Comment on attachment 381215 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=381215&action=review

> Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py:189
> +            message += '\n\n' + self._steps_messages(build)

How long can this get?

Looking at your example, the tooltip is totally reasonable, but it seems like we don't actually have a limit on how many builds you have here
Comment 4 Aakash Jain 2019-10-17 13:37:49 PDT
(In reply to Jonathan Bedard from comment #3)
> > Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py:189
> > +            message += '\n\n' + self._steps_messages(build)
> 
> How long can this get?
We are not limiting anything currently.
> 
> Looking at your example, the tooltip is totally reasonable, but it seems like we don't actually have a limit on how many builds you have here
We can have the problem of too much text even with a single build. Not sure what's a good limit to put. Maybe we can land this patch as is, and see if and how exactly do we hit this issue of too much text, and then solve it appropriately.
Comment 5 WebKit Commit Bot 2019-10-17 14:02:52 PDT
Comment on attachment 381215 [details]
Patch

Clearing flags on attachment: 381215

Committed r251256: <https://trac.webkit.org/changeset/251256>
Comment 6 WebKit Commit Bot 2019-10-17 14:02:53 PDT
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2019-10-17 14:03:26 PDT
<rdar://problem/56384566>
Comment 8 Aakash Jain 2019-10-18 06:37:18 PDT
Deployed in production.